Bug 273889 - emulators/pcsx2: Fails to build with fmt 10+
Summary: emulators/pcsx2: Fails to build with fmt 10+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on:
Blocks: 273463
  Show dependency tree / graph
 
Reported: 2023-09-17 10:22 UTC by Daniel Engberg
Modified: 2023-09-28 10:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ganael LAPLANCHE freebsd_committer freebsd_triage 2023-09-19 10:29:34 UTC 
Hello Daniel,

Weird, only PCSX2-provided fmt should be used, not the system one.

Is your fmt update patch available somewhere so that I can try to reproduce the build error ?

Thanks in advance,

Ganael.
Comment 3 Ganael LAPLANCHE freebsd_committer freebsd_triage 2023-09-20 05:40:10 UTC 
Thanks!
Comment 4 Ganael LAPLANCHE freebsd_committer freebsd_triage 2023-09-20 10:55:34 UTC 
Hmmmm... It builds correctly with new FMT :

http://box.martymac.org/FreeBSD-Packages/data/FBSD132amd64-default/2023-09-20_11h49m40s/logs/pcsx2-1.7.4970_1.log

Do you have a special setting on your builder box ?
Comment 5 Ganael LAPLANCHE freebsd_committer freebsd_triage 2023-09-22 05:39:34 UTC 
OK, this is on 12.4, sorry.

Actually it already fails to build on 12.4:

https://pkg-status.freebsd.org/beefy6/data/124amd64-default/2c18c2a2da98/logs/pcsx2-1.7.4970.log

I still have to investigate but those build problems are not related to fmt so you can proceed to updating it.

Best regards,

Ganael.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-09-22 20:07:11 UTC 
Great! Thanks for the heads up!
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-28 10:44:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=db9dbfa336ebd7bb0d93d7a2638fc1d2b7505434

commit db9dbfa336ebd7bb0d93d7a2638fc1d2b7505434
Author:     Ganael LAPLANCHE <martymac@FreeBSD.org>
AuthorDate: 2023-09-28 10:41:21 +0000
Commit:     Ganael LAPLANCHE <martymac@FreeBSD.org>
CommitDate: 2023-09-28 10:41:21 +0000

    emulators/pcsx2: Mark as BROKEN before 13.2

    Pcsx2 needs a libc++ with std::bit_cast support (introduced in 13.2
    with commit 4b6eb0e63c69)

    PR:             273889
    Reported by:    diizzy

 emulators/pcsx2/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 8 Ganael LAPLANCHE freebsd_committer freebsd_triage 2023-09-28 10:46:37 UTC 
Hello Daniel,

I had to mark the port as BROKEN before 13.2 because it needs std::bit_cast support introduced with commit 4b6eb0e63c69.

Regarding fmt update, there is no direct dependency so you can proceed to updating it.

Best regards,

Ganael.