Bug 273904 - multimedia/libx264 doesn't build on my 14.0-STABLE system with PGO option set
Summary: multimedia/libx264 doesn't build on my 14.0-STABLE system with PGO option set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-17 15:53 UTC by sven.a.jonsson
Modified: 2023-09-29 06:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
Log from failed configuration. (6.89 KB, text/plain)
2023-09-17 15:53 UTC, sven.a.jonsson 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sven.a.jonsson 2023-09-17 15:53:56 UTC 
Created attachment 244977 [details]
Log from failed configuration.

When rebuilding all my ports with poudriere after upgrade, multimedia/libx264 fail in configure. As can be seen in the attached logfile from workdir it is probably due to a mismatch of expected names of compiler warning options and what options gcc12 provides.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-09-17 21:14:36 UTC 
Out of curiosity, do you see any improvments having PGO enabled?
Comment 2 sven.a.jonsson 2023-09-18 04:33:00 UTC 
Never really noticed any improvements, on the other hand I never really looked for them or measured. The PGO flag is just there in the poudriere make.conf because it doesn't hurt, and as an ex gentooer I couldn't resist:D
Comment 3 sven.a.jonsson 2023-09-26 05:30:29 UTC 
After some testing, it turns out that it is the PGO option that causes the errors. Disabling PGO makes poudriere fetch the prebuilt libx264. Disabling OPENCL makes poudriere successfully rebuild libx264.
So I updated the title to better reflect what the issue is.
I am not in any particular need for the PGO option (I just set it globally because its there :).
And now firefox, thunderbird and ffmpeg builds properly, so I am am OK with how things are.
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-28 19:21:21 UTC 
libx264 do not have any PGO option so I believe you wanted to mean PGO for multimedia/x264. Am I correct?
Comment 5 sven.a.jonsson 2023-09-28 20:25:11 UTC 
I think it has the PGO option indirectly from multimedia/x264, so the answer is yes:

❯ pkg options|grep PGO
libx264 - PGO: on

The makefile contains
---------------------------
MASTERDIR=	${.CURDIR}/../x264

and
---------------------------
pre-build:

.include "${MASTERDIR}/Makefile"
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-09-28 20:27:33 UTC 
No problem. Will fix the commit tomorrow.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-29 06:53:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d26aa987ba6a52e0a7b295128008a9f0af96e2b8

commit d26aa987ba6a52e0a7b295128008a9f0af96e2b8
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2023-09-28 19:55:09 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-09-29 06:02:01 +0000

    multimedia/{lib}x264: Fix build with PGO

    - Pet portclippy
    PR:             273904
    Reported by:    sven.a.jonsson@bahnhof.se

 multimedia/x264/Makefile | 51 ++++++++++++++++++++++--------------------------
 1 file changed, 23 insertions(+), 28 deletions(-)