Bug 273909 - security/libfido2: Unbreak build with DEFAULT_VERSIONS=ssl=openssl30
Summary: security/libfido2: Unbreak build with DEFAULT_VERSIONS=ssl=openssl30
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-17 20:24 UTC by Craig Leres
Modified: 2023-10-16 16:51 UTC (History)
4 users (show)

See Also:
sunpoet: maintainer-feedback+

Attachments
patch (570 bytes, patch)
2023-09-17 20:25 UTC, Craig Leres 		leres: maintainer-approval?
Details | Diff
adjusted patch (401 bytes, patch)
2023-10-12 20:07 UTC, Craig Leres 		leres: maintainer-approval? (sunpoet)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2023-09-17 20:24:43 UTC 
I wanted to try building ports with openssl 3.0 and clearly folks have been busy because the only thing that failed to build was libfido2 (with many deprecation errors). Here's a minimal patch to work around that. (In the long run I assume yubico will add support for openssl 3.)
Comment 1 Craig Leres freebsd_committer freebsd_triage 2023-09-17 20:25:08 UTC 
Created attachment 244982 [details]
patch
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-10-01 00:34:18 UTC 
(In reply to Craig Leres from comment #1)

I'm OK with this change. Please add this one after ".if ${SSL_DEFAULT} == base" section. Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-04 01:36:42 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f659f82a39062ee43e69e81aad815c31e5d5d68

commit 1f659f82a39062ee43e69e81aad815c31e5d5d68
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2023-10-04 01:35:51 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2023-10-04 01:35:51 +0000

    security/libfido2: Unbreak build with DEFAULT_VERSIONS=ssl=openssl30

    Use OPENSSL_API_COMPAT to fix build on FreeBSD 13.2 with
    DEFAULT_VERSIONS=ssl=openssl30

    PR:             273909
    Approved by:    sunpoet (maintainer)

 security/libfido2/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 4 Craig Leres freebsd_committer freebsd_triage 2023-10-12 20:07:07 UTC 
@arrowd reports that, "security/openssl30 is going to be removed from ports shortly" in bug 274419. Here's an updated patch to work with openssl3X (I've tested it openssl31).
Comment 5 Craig Leres freebsd_committer freebsd_triage 2023-10-12 20:07:44 UTC 
Created attachment 245592 [details]
adjusted patch
Comment 6 Chad Jacob Milios 2023-10-16 02:25:03 UTC 
would it be better to test OPENSSL_SHLIBVER instead of SSL_DEFAULT?

would it not be feasible that we:

1. assume that the mere definition of OPENSSL_SHLIBVER doesnt currently by any port necessarily imply the use of an ssl implementation from ports rather than from base (or fix some small number that do)?

2. set OPENSSL_SHLIBVER in Mk/Uses/ssl.mk according to __FreeBSD_version, even when SSL_DEFAULT == base
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-10-16 16:49:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2a1f1b7c3664cde187ac5b507b6a5a1ba18a1daf

commit 2a1f1b7c3664cde187ac5b507b6a5a1ba18a1daf
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-10-16 16:48:54 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-10-16 16:48:54 +0000

    security/libfido2: Simplified Makefile

    OPENSSL_API_COMPAT=0x10101000L can be set unconditionally.

    from CMakeLists.txt:
            if(CRYPTO_VERSION VERSION_GREATER_EQUAL 3.0)
                    add_definitions(-DOPENSSL_API_COMPAT=0x10100000L)
            endif()

    PR:             273909

 security/libfido2/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Comment 8 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-10-16 16:51:39 UTC 
This should be OK for openssl, openssl-quictls, openssl31 and openssl32.