Bug 273963 - devel/cpp2py: remove llvm10 dependency
Summary: devel/cpp2py: remove llvm10 dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-20 11:06 UTC by Brooks Davis
Modified: 2023-09-21 03:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
remove needless llvm dependency (921 bytes, patch)
2023-09-20 11:06 UTC, Brooks Davis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2023-09-20 11:06:51 UTC
Created attachment 245046 [details]
remove needless llvm dependency

The llvm dependency and FREEBSD_LLVM_VER CMAKE argument don't appear to be required and the patch for FREEBSD_LLVM_VER was removed at some point in the past.

I'm skeptical that PYTHON_INTERPRETER is required, but I've not touched it for now.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2023-09-20 15:54:38 UTC
(In reply to Brooks Davis from comment #0)
> LLVM_VER=	10
Remove this too?
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-09-20 17:03:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e46126d5d35bf996048bcaa47d4de3a7fc7aa75d

commit e46126d5d35bf996048bcaa47d4de3a7fc7aa75d
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2023-09-20 15:55:42 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2023-09-20 17:02:00 +0000

    devel/llvm10: deprecate, set short expiration

    All dependent ports appear not to depend on llvm10 in practice and I've
    submitted PRs for them.  Set an expiration (somewhat shorter than ideal)
    so llvm10 doesn't end up in 2023Q4.

    PR:             273963, 273964, 273977

 devel/llvm10/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-09-21 03:15:37 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-09-21 03:19:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb7459705bbf7ae511e33df615e7a875929a57da

commit cb7459705bbf7ae511e33df615e7a875929a57da
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2023-09-21 03:17:57 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-09-21 03:17:57 +0000

    devel/cpp2py: Remove llvm10 dependency

    cpp2py builds fine with llvm-16

    PR:             273963

 devel/cpp2py/Makefile | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)