Bug 274054 - net-p2p/transmission-daemon: Setting Log Level Causes Transmission to Not Start
Summary: net-p2p/transmission-daemon: Setting Log Level Causes Transmission to Not Start
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-23 19:20 UTC by Matt
Modified: 2023-09-30 20:03 UTC (History)
3 users (show)

See Also:
mondo.debater_0q: maintainer-feedback+


Attachments
Patch (697 bytes, patch)
2023-09-23 19:21 UTC, Matt
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt 2023-09-23 19:20:47 UTC
Should --log-level with ' ' not '='

--log-level <level> Must be 'critical', 'error', 'warn', 'info', 'debug', or 'trace'.
Comment 1 Matt 2023-09-23 19:21:12 UTC
Created attachment 245171 [details]
Patch
Comment 2 Rafe 2023-09-24 08:10:17 UTC
(In reply to Matt from comment #0)

Thanks for reporting this! Note the issue is the lack of a dash between "loglevel," not the use of an equals sign. It works equally well with and without an equals sign.

I will submit a patch upstream to align the man page with the output of --help.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-24 21:17:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c4dfbd3671ebfbbe2c2e527adf66babc89366208

commit c4dfbd3671ebfbbe2c2e527adf66babc89366208
Author:     Matt <lazeraman@gmail.com>
AuthorDate: 2023-09-24 21:12:37 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-09-24 21:16:11 +0000

    net-p2p/transmission: Fix log level option

    Syntax for option is "--log-level n" and not "--log-level=n"

    PR:             274054
    Reviewed by:    Rafe <mondo.debater_0q@icloud.com> (maintainer)

 net-p2p/transmission/Makefile              | 2 +-
 net-p2p/transmission/files/transmission.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-09-24 21:21:20 UTC
Committed, thanks
Comment 5 Matt 2023-09-25 14:05:16 UTC
The change did not change loglevel to log-level. The issue is still present.
Comment 6 Rafe 2023-09-25 14:29:22 UTC
(In reply to Matt from comment #5)
Yeah, I'm confused by what was committed here. It's not the patch that you submitted.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-25 23:40:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c066fcda40f7ef87e5e86458655082aedf0c1b5

commit 3c066fcda40f7ef87e5e86458655082aedf0c1b5
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-09-25 23:31:49 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-09-25 23:37:06 +0000

    net-p2p/transmission: Fix log level option again

    Previously attempt only applied submitted patch partially,
    option is also named --log-level not --loglevel

    PR:             274054
    Reported by:    Matt <lazeraman@gmail.com>

 net-p2p/transmission/Makefile              | 2 +-
 net-p2p/transmission/files/transmission.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2023-09-25 23:41:03 UTC
The submitted patch didn't apply so I did it manually and by doing so I missed that it also changed the name of the switch itself. Sorry
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-09-30 20:01:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac3e39992e95659a5193a15d4cb873efb00fcb30

commit ac3e39992e95659a5193a15d4cb873efb00fcb30
Author:     Rafe <mondo.debater_0q@icloud.com>
AuthorDate: 2023-09-24 20:04:16 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-30 20:00:01 +0000

    net-p2p/transmission: Reorganize as a metaport

    Port reorganized as a metaport. Each component can be installed
    separately or selected as an option via the metaport.  Components
    were moved to net-p2p/transmission-components.
    See MOVED for additional information.

    Also fixes log-level typo in rc file and description errors

    PR:             273841, 274054 274065
    Reported by:    Anton Saietskii <vsasjason@gmail.com>
    Reported by:    Matt <lazeraman@gmail.com>
    Reported by:    Benjamin Takacs <nimaje+fbz@bureaucracy.de>
    Differential Revision: https://reviews.freebsd.org/D41975

 MOVED                                              |  12 +-
 UPDATING                                           |  10 ++
 net-p2p/Makefile                                   |   1 +
 net-p2p/transmission-components/Makefile (new)     | 189 +++++++++++++++++++++
 .../distinfo                                       |   0
 .../files/patch-CMakeLists.txt}                    |   0
 .../files/patch-gtk_Application.cc                 |   0
 .../files/patch-gtk_DetailsDialog.cc               |   0
 .../files/patch-libtransmission_file-posix.cc      |   0
 .../files/patch-libtransmission_variant-json.cc    |   0
 .../files/patch-qt_transmission-qt.desktop (new)   |  11 ++
 .../files/transmission.in                          |   0
 .../transmission-components/pkg-descr.cli (new)    |   1 +
 .../transmission-components/pkg-descr.daemon (new) |   9 +
 .../transmission-components/pkg-descr.docs (new)   |   1 +
 .../transmission-components/pkg-descr.gtk (new)    |   1 +
 net-p2p/transmission-components/pkg-descr.qt (new) |   1 +
 .../transmission-components/pkg-descr.utils (new)  |   1 +
 .../pkg-plist.cli                                  |   0
 .../transmission-components/pkg-plist.daemon (new) |   9 +
 .../transmission-components/pkg-plist.docs (new)   |  10 ++
 .../pkg-plist.gtk                                  |   0
 .../pkg-plist.qt                                   |   2 +-
 .../pkg-plist.utils                                |   0
 net-p2p/transmission/Makefile                      | 186 ++------------------
 net-p2p/transmission/pkg-plist.daemon (gone)       |  19 ---
 net-p2p/transmission/pkg-plist.default (gone)      | 155 -----------------
 27 files changed, 264 insertions(+), 354 deletions(-)
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2023-09-30 20:03:33 UTC
Thank you for your contribution.
I hope this design finally fixes transmission.