Bug 274190 - mail/claws-mail: links with net/openldap26-client if installed
Summary: mail/claws-mail: links with net/openldap26-client if installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Chris Hutchinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-01 03:12 UTC by Ivan Rozhuk
Modified: 2024-02-08 08:27 UTC (History)
5 users (show)

See Also:

Attachments
git diff to correct options handling for mail/claws-mail (906 bytes, patch)
2024-01-23 09:38 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2023-10-01 03:12:56 UTC 
claws-mail is missing a required shared library: libldap.so.2
claws-mail is missing a required shared library: liblber.so.2
after install claws-mail on system without libreoffice.
Build host have libreoffice and net/openldap26-client as dep.
Comment 1 Xin LI freebsd_committer freebsd_triage 2023-10-01 05:14:38 UTC 
The problem is that Makefile.claws is incorrectly overriding CONFIGURE_ARGS.  This makes all option-derived CONFIGURE_ARGS to get lost.

Something like this would fix it.


===
diff --git a/mail/claws-mail/Makefile.claws b/mail/claws-mail/Makefile.claws
index 53ee30e66310..9ea0a1b576fe 100644
--- a/mail/claws-mail/Makefile.claws
+++ b/mail/claws-mail/Makefile.claws
@@ -8,7 +8,7 @@ LICENSE=        GPLv3
 USES+=         autoreconf gettext-tools gmake iconv libtool pkgconfig tar:xz
 GNU_CONFIGURE= yes
 
-CONFIGURE_ARGS=        ${ICONV_CONFIGURE_ARG} --disable-dbus --disable-static
+CONFIGURE_ARGS+=       ${ICONV_CONFIGURE_ARG} --disable-dbus --disable-static
 
 .include "${.CURDIR}/../claws-mail/Makefile.ver"
 .include "${.CURDIR}/../claws-mail/Makefile.claws.plugins"
Comment 2 bsd 2023-10-01 05:45:22 UTC 
(In reply to Xin LI from comment #1)
Testing proposed patch...
Comment 3 bsd 2023-10-01 20:06:56 UTC 
Building Claws Mail with OPTION LDAP both on and off for both GTK2 and GTK3 version succeeds with proposed patch applied. All those builds are basically clean ones, in a dedicated jail. So patch proposed by Xin Li is not damaging anything, from my point of view. OP should test whether Xin's patch solves his issue.
Comment 4 Chris Hutchinson 2024-01-23 09:38:06 UTC 
Created attachment 247876 [details]
git diff to correct options handling for mail/claws-mail

Xin Li is absolutely correct. I don't know how I ever let this pass.
This is an attachment that implements his proposal. Please commit.

Thanks!

--Chris
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-02-08 08:19:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ae03dfaa96e334b41d1f41297aadd99508fc0f49

commit ae03dfaa96e334b41d1f41297aadd99508fc0f49
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-02-08 08:15:56 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2024-02-08 08:15:56 +0000

    mail/claws-mail: Link with net/openldap26-client if installed.

    Reported by:    Ivan Rozhuk <rozhuk.im@gmail.com>
    PR:             274190
    MFH:            2024Q1

 mail/claws-mail/Makefile       | 2 +-
 mail/claws-mail/Makefile.claws | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-02-08 08:26:13 UTC 
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eef29c1b80fabb8262cb15ba93be0472b2448e39

commit eef29c1b80fabb8262cb15ba93be0472b2448e39
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-02-08 08:15:56 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2024-02-08 08:24:58 +0000

    mail/claws-mail: Link with net/openldap26-client if installed.

    Reported by:    Ivan Rozhuk <rozhuk.im@gmail.com>
    PR:             274190
    MFH:            2024Q1

    (cherry picked from commit ae03dfaa96e334b41d1f41297aadd99508fc0f49)

    This commit does not contain the switch to share/man for manpages.

 mail/claws-mail/Makefile       | 2 +-
 mail/claws-mail/Makefile.claws | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 7 Juraj Lutter freebsd_committer freebsd_triage 2024-02-08 08:27:00 UTC 
Committed, thanks.