Bug 274203 - math/openturns: remove a deprecated option to chase ceres-solver 2.2.0
Summary: math/openturns: remove a deprecated option to chase ceres-solver 2.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on: 274200
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-01 20:43 UTC by Thierry Thomas
Modified: 2023-10-02 17:02 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+


Attachments
Remove use_postordering (1.34 KB, patch)
2023-10-01 20:43 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2023-10-01 20:43:17 UTC
Created attachment 245363 [details]
Remove use_postordering

math/openturns fails with ceres-solver-2.2.0rc1, because it uses use_postordering, which was a deprecated option and has been removed in 2.2.0.

See https://github.com/ceres-solver/ceres-solver/issues/1009#issuecomment-1742181490 .
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-10-02 00:33:49 UTC
Hi Thierry,

Thanks for the patch.

Approved. Please commit it.

Also please add the comment into the patch saying why is this patch needed.


Thanks,
Yuri
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-02 17:02:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=104cc29607554a81cbb8d1e3b28721a87e190bf8

commit 104cc29607554a81cbb8d1e3b28721a87e190bf8
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2023-10-02 16:36:01 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2023-10-02 17:01:36 +0000

    math/openturns: remove a deprecated option to chase ceres-solver 2.2.0

    PR:             274203
    Approved by:    yuri (maintainer)

 math/openturns/Makefile                                       |  2 +-
 math/openturns/files/patch-lib_src_Base_Optim_Ceres.cxx (new) | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2023-10-02 17:02:29 UTC
Committed, thanks!