Created attachment 245402 [details] v0 # portlint -N /usr/ports/net-p2p/tremotesf/ && portclippy /usr/ports/net-p2p/tremotesf/Makefile WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. 0 fatal errors and 1 warning found. #
Created attachment 245403 [details] poudriere testport log
Just in case a screenshot: https://imgur.com/Mk3QLXL.png
Comment on attachment 245402 [details] v0 > Tremotesf is yet another, but modern cross-platfom GUI for Transmission daemon > written in C++ and Qt. I can't guess (don't need to know) how many others are ported, but maybe you can make the description more distinctive; to help readers begin to decide which ports to investigate further. I took a quick look in GitHub, and at <https://explore.transifex.com/equeim/tremotesf/>. Selling points might include something like "first released in 2016" and "fully translated in four languages". Just a thought, and thanks for contributing.
(In reply to Graham Perrin from comment #3) I'm actually aware only of net-p2p/transmission-remote-gui, which is written in FreePascal + Lazarus, but became abandonware in 2019 (that's about what we have in ports, not what other clients I know about). But I do agree that pkg-descr can be better (?), however didn't came to that yet. Wanted just copy description from original project, but it's even shorter than mine variant. Not sure if anybody cares about release date and translations (at least I don't), but it's basically a GUI which has no issues found by me.
Created attachment 245411 [details] v1 Taken the feature list from Google Play description to improve pkg-descr.
Thank you for your submission. Looks pretty good! If the project has unit tests, check if you can hook them up to the Makefile. There's infrastructure such that "make test" on the port can execute unit tests, which makes checking updates easier. Read the Porter's Handbook for details. I recommend using the full commit hash for GH_TAGNAME as it's guaranteed not to be ambiguous. Short hashes may become ambiguous when the repository grows. Is it correct that this port does not depend on transmission in any way? It looks weird, but perhaps that's just the way it is. Proceeding with a build test now.
(In reply to Robert Clausecker from comment #6) Robert, Tremotesf does indeed have some tests, but I planned to enable them later. Need to dig into "test" target and its relation to TEST option which some ports have (TBH, I don't fully understand yet why do we need option at all and why don't just run "test" target or not run it). Regarding the commit has — taken into account. And regarding the transmission depends: exactly, none of then exist. Tremotesf just connects to daemon through HTTP and uses its API, and that daemon could be anywhere.
Build test looks good. Will commit with my next batch. The TESTS option some ports have is for building and/or installing test files in the package. Some people want these, some don't. This is orthogonal to supporting the "test" target. Please see if you can get the tests added in a future commit.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b32bba6b239c7fe63266a04d2e5a6268d51beff7 commit b32bba6b239c7fe63266a04d2e5a6268d51beff7 Author: Anton Saietskii <vsasjason@gmail.com> AuthorDate: 2023-10-02 13:34:32 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-04 20:01:38 +0000 net-p2p/tremotesf: add new port Tremotesf is yet another, but modern (first-released in 2016) cross-platfom GUI for Transmission daemon written in C++ and Qt. Features include, but not necessarily limited to: * View torrent list * Sort torrents * Filter torrents by name, status and trackers * Start/stop/verify/remove torrents with multi-selection * Add torrents from torrent files and magnet links * Select which files to download when adding torrent * Manage torrent files * Add and remove torrent trackers * View torrent peers * Set torrent limits * Change remote server settings * View server statistics * Multiple servers * Supports HTTPS connection * Can connect to servers with self-signed certificates (you need to add certificate to server settings) * Client certificate authentication WWW: https://github.com/equeim/tremotesf2/ PR: 274236 net-p2p/Makefile | 1 + net-p2p/tremotesf/Makefile (new) | 32 ++++++++++++++++++++++++++++++++ net-p2p/tremotesf/distinfo (new) | 5 +++++ net-p2p/tremotesf/pkg-descr (new) | 21 +++++++++++++++++++++ net-p2p/tremotesf/pkg-plist (new) | 10 ++++++++++ 5 files changed, 69 insertions(+)