Created attachment 245474 [details] 1.15.4 -> 1.16.1 Patch Time once again for my seasonal bout of frustration with this software to produce an update! :) Moving the port to the new and improved 1.16.1 release. Notable changes: * SSL/TLS build is now mandatory (“Because it’s 2023, deal with it!”) * PAM, SASL, and zlib are now properly optional * PAM, SASL, and zlib options are now properly exposed in the port * SASL correctly pulls in security/cyrus-sasl2 & libsasl2.so as port dependencies * We can safely use DISTVERSION instead of PORTVERSION * libsnet (bundled) is now taken from my github repo, fixes there include all the above plus FreeBSD 14 warnings about missing prototypes are dealt with. Gave it a scrub with portlint, portclippy, and “port test” because I still haven’t set up poudriere at work yet. I left PORTREVISION=0 in the Makefile but otherwise looks clean. Build tested on 12.4-RELEASE-p3 & 14.0-BETA4 ; linting all done on 14.0-BETA4.
Comment on attachment 245474 [details] 1.15.4 -> 1.16.1 Patch Please remember to set the patch flag on patches you submit so they can be viewed in our online diff viewer.
Note that we ship zlib in base, so there's often not really a reason to make it optional. It's ok to have the option though. On commit, I will replace your ${CP} command in post-install with an INSTALL_DATA command as per policy. There is usually no reason to manually install license files as we install them automatically through our port license framework. It's not forbidden to do so though.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d5a284d59a370890732d9d0584fa030e31030c49 commit d5a284d59a370890732d9d0584fa030e31030c49 Author: Michael Graziano <mikeg@bsd-box.net> AuthorDate: 2023-10-07 04:32:53 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-09 07:40:31 +0000 sysutils/radmind: 1.15.4 -> 1.16.1 Update Time once again for my seasonal bout of frustration with this software to produce an update! :) Moving the port to the new and improved 1.16.1 release. Notable changes: * SSL/TLS build is now mandatory (“Because it’s 2023, deal with it!”) * PAM, SASL, and zlib are now properly optional * PAM, SASL, and zlib options are now properly exposed in the port * SASL correctly pulls in security/cyrus-sasl2 & libsasl2.so as port dependencies * We can safely use DISTVERSION instead of PORTVERSION * libsnet (bundled) is now taken from my github repo, fixes there include all the above plus FreeBSD 14 warnings about missing prototypes are dealt with. PR: 274320 sysutils/radmind/Makefile | 24 ++++++++++++++---------- sysutils/radmind/distinfo | 6 +++--- 2 files changed, 17 insertions(+), 13 deletions(-)
Thank you for your contribution.