Created attachment 245533 [details] patch-file for mail/aerc Update mail/aerc to 0.16.0 I'd like to take maintainership of the port.
Thank you! <https://www.freshports.org/mail/aerc/> at 0.10.0_11 <https://git.sr.ht/~rjarry/aerc/refs/0.11.0> <https://git.sr.ht/~rjarry/aerc/refs/0.12.0> <https://git.sr.ht/~rjarry/aerc/refs/0.13.0> <https://git.sr.ht/~rjarry/aerc/refs/0.14.0> <https://git.sr.ht/~rjarry/aerc/refs/0.15.0> <https://git.sr.ht/~rjarry/aerc/refs/0.16.0>
Is there a changelog for this update? Instead of moving the Makefile, you can set the MAKEFILE variable to the actual name of the Makefile. You might want to change the port so it uses the GO_MODULE mechanism to have the Go tooling download the required files (if that works in this case). This would remove the need for all the complicated handling of extra dependencies. The port currently ignores CFLAGS and CPPFLAGS. Make sure it respects them. I can see this as the output has cc -O2 -g -o colorize filters/colorize.c without the usual -fstack-protector-strong etc. This can perhaps be fixed by invoking make properly (and please do it separately for build and install if possible): (cd ${WRKSRC} && ${DO_MAKE_BUILD} ${ALL_TARGET}) and later to install, (cd ${WRKSRC} && ${DO_MAKE_BUILD} ${INSTALL_TARGET}) If you have USES=gmake, this automatically picks GNUmake. Furthermore, make sure installed binaries are stripped. stage-qa complains: ====> Running Q/A tests (stage-qa) Warning: 'libexec/aerc/filters/colorize' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: 'libexec/aerc/filters/wrap' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: you might not need LIB_DEPENDS on libnotmuch.so Also please set VERSION in MAKE_ARGS so the port doesn't try to invoke git to find the version (this frequently goes wrong if the ports tree is managed via git; go figure). In fact, since we build the main binary via USES=go's default do-build rule, you should also carry over all the other bits that go into GO_BUILDFLAGS.
@GrahamPerrin Note that by marking this bug as "open", you have succeeded in kicking it off the "needs triage" list, meaning that possibly nobody is ever going to look at it again (as it doesn't have a maintainer-approved patch and nothing to time out). Is this really the intent? You really shouldn't set random bugs to "open" without being sure that they are filed somewhere people look.
Changelog: https://git.sr.ht/~rjarry/aerc/refs/0.16.0 # Added - JMAP support. - The new account wizard now supports all source and outgoing backends. - Edit email headers directly in the text editor with `[compose].edit-headers` in `aerc.conf` or with the `-e` flag for all compose related commands (e.g. `:compose`, `:forward`, `:recall`, etc.). - Use `:save -A` to save all the named parts, not just attachments. - The `<Backspace>` key can now be bound. - `colorize` can style diff chunk function names with `diff_chunk_func`. - Warn before sending emails with an empty subject with `empty-subject-warning` in `aerc.conf`. - IMAP now uses the delimiter advertised by the server. - `carddav-query` utility to use for `address-book-cmd`. - Folder name mapping with `folder-map` in `accounts.conf`. - Use `:open -d` to automatically delete temporary files. - Remove headers from the compose window with `:header -d <name>`. - `:attach -r <name> <cmd>` to pipe the attachments from a command. - New `msglist_gutter` and `msglist_pill` styles for message list scrollbar. - New `%f` placeholder to `file-picker-cmd` which expands to a location of a temporary file from which selected files will be read instead of the standard output. - Save drafts in custom folders with `:postpone -t <folder>`. - View "thread-context" in notmuch backends with `:toggle-thread-context`. # Fixed - `:archive` now works on servers using a different delimiter - `:save -a` now works with multiple attachments with the same filename - `:open` uses the attachment extension for temporary files, if possible - memory leak when using notmuch with threading # Changed - Names formatted like "Last Name, First Name" are better supported in templates - Composing an email is now aborted if the text editor exits with an error (e.g. with `vim`, abort an email with `:cq`). - Aerc builtin filters path (usually `/usr/libexec/aerc/filters`) is now **prepended** to the default system `PATH` to avoid conflicts with installed distro binaries which have the same name as aerc builtin filters (e.g. `/usr/bin/colorize`). - `:export-mbox` only exports marked messages, if any. Otherwise it exports everything, as usual. - The local hostname is no longer exposed in outgoing `Message-Id` headers by default. Legacy behaviour can be restored by setting `send-with-hostname = true` in `accounts.conf`. - The notmuch bindings were replaced with internal bindings - Aerc now has a default style for most UI elements. The `default` styleset is now empty. Existing stylesets will only override the default attributes if they are set explicitly. To reset the default style and preserve existing stylesets appearance, these two lines must be inserted **at the beginning**: ``` *.default=true *.normal=true ``` # Deprecated - Aerc can no longer be compiled and installed with BSD make. GNU make must be used instead.
Created attachment 245541 [details] updated patch file mail/aerc
I've updated the patch with suggested changes. I couldn't build the package with GO_MODULE because the version name in the pkg.go.dev repository is different(v0.0.0-20230927211642-61bca76423ee which corresponds to aerc version 0.15.2).
Comment on attachment 245541 [details] updated patch file mail/aerc Sorry there was a typo.
Created attachment 245542 [details] updated patch file mail/aerc
Looks great, thanks! Note that it's spelled ALL_TARGET, not ALL_TARGETS. Will fix that on commit. I'll also add the missing BUILD_DEPENDS on converters/base64.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c559a8b10be66a8d4f65979ec5bb2547442e55ae commit c559a8b10be66a8d4f65979ec5bb2547442e55ae Author: Yuvakiran Rayapureddy <iamsleepy@ryuki.me> AuthorDate: 2023-10-10 04:22:06 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-11 06:04:38 +0000 mail/aerc: Update to 0.16.0 - clean up and improve port Submitter becomes maintainer. Changelog: https://git.sr.ht/~rjarry/aerc/refs/0.16.0 PR: 274383 mail/aerc/Makefile | 119 ++++++++++++--------- mail/aerc/distinfo | 146 ++++++++++++++------------ mail/aerc/files/patch-filters_colorize (gone) | 8 -- mail/aerc/pkg-plist | 26 +++-- 4 files changed, 165 insertions(+), 134 deletions(-)
Thank you for your contribution.