Created attachment 245572 [details] Update to 5.1.11 This patch updates to the current 5.1.11. I've tested it on 13.2-RELEASE-p4, though I don't really have any other hosts to test on.
Thanks, I will look into it shortly. I remember from working on it that it wasn't just a simple update. The service script couldn't find Java and it never started. I still need to verify that upgrading from an older version does not break the installation.
I haven't had any issues with it not finding Java, but the issues I've seen with upgrades have been related to old JARs left lying around in /usr/local/share/nzbhydra2/lib. Each new version comes with one (core-${VERSION_NUMBER}-exec.jar), but the application refuses to start if there's more than one JAR in that directory. It seems that upgrading doesn't remove the old JARs, which leads to errors. I'm not really sure what the best way is to resolve that, though.
Oh, I should probably mention that I use packages for everything (even with this, I build a package and then install it). I'm not sure what the behavior is for ports with upgrading, but I'd imagine it's similar.
Created attachment 246457 [details] Update news/nzbhydra2 to 5.3.3 and ensure lib/ only contains the current .jar file 5.3.3 was just released, and the new wrapper file in it contains a fix for what was probably causing the issues with not being able to find java. There was a bug in the old version which was causing it to overwrite the java parameter. So, this updates to 5.3.3. I also added a line to the startup script to clean out the lib/ directory and remove any file which doesn't match the current .jar file, since that should be the only file in there. This should ensure that, no matter what, there aren't any issues with upgrades. From talking with folks, apparently some of the code paths that pkg takes for local packages can leave old files around, which is likely how that was happening with files in the lib/ directory, but this would compensate for that.
I've been ill the last couple of weeks and couldn't take a look at all this. Now I could and it works as expected, updating works smoothly. Thank you very much for the effort. Looks ready to be merged.
I don't know whether if someone has checked this or not but there are additional files being installed which are not mentioned in the PLIST_FILES. Should I remove those files or should I add those files? https://pkg.bofh.network/data/124-default/2023-12-10_10h03m00s/logs/errors/nzbhydra2-5.3.3.log
Oh, good catch. Those can get deleted. The .exe files are (obviously) compiled for Windows, and the files in the executables directory are compiled binaries for Linux, none of which we need. The "other" directory contains scripts for various startup systems, which are unneeded since this package includes its own.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e276e87ae4bf600e4899a21ad0f91984b4f89188 commit e276e87ae4bf600e4899a21ad0f91984b4f89188 Author: Kreeblah <kreeblah@gmail.com> AuthorDate: 2023-12-12 16:38:07 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2023-12-12 16:38:07 +0000 news/nzbhydra2: Update version 4.7.4=>5.3.3 Changelog: https://github.com/theotherp/nzbhydra2/releases/tag/v5.3.5 PR: 274418 Approved by: submitter is maintainer news/nzbhydra2/Makefile | 17 ++++++++--------- news/nzbhydra2/distinfo | 6 +++--- news/nzbhydra2/files/nzbhydra2.in | 2 ++ 3 files changed, 13 insertions(+), 12 deletions(-)