Bug 274433 - ports-mgmt/poudriere: broken option logic after introducing portconfig
Summary: ports-mgmt/poudriere: broken option logic after introducing portconfig
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-12 15:38 UTC by Anton Saietskii
Modified: 2023-10-12 20:53 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (bdrewery)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-10-12 15:38:59 UTC
0cae7336b7c9fcfceac895ee6b9104e01d6a04d1 and next 5 commits introduced some mess in options and this is not fixed at the moment of creating this PR:
* PORTCONFIG option says "install _dialog4ports_ ..." in its description;
* Actual support for dialog4ports is removed in port options, but still available in files/patch-portconfig. According to that patch, it was meant to _add_ portconfig support, not _replace_ dialog4ports with it (or the patch is incorrect).

I believe following is the right way:
* restore original DIALOG4PORTS option
* add PORTCONFIG option and set correct description
* make both options grouped (according to code, RADIO isn't required as multiselect will work)
* set whatever option as default, but allow those who used DIALOG4PORTS to continue that
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2023-10-12 20:50:41 UTC
there is no plan in continuing to use dialog4ports, it is broken on head right now because it is being decommissioned, the current state is working the only bug is the description in the non devel version, which I am about to fix.

The code itself allows both dialog4ports and portconfig to remain as conservative as possible and allow smooth transition for users, but poudriere package is tracking what is the default in the ports tree.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-12 20:52:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cf0e7ae70e4268d867502b271c3d08189ab80f80

commit cf0e7ae70e4268d867502b271c3d08189ab80f80
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2023-10-12 20:35:00 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2023-10-12 20:51:48 +0000

    ports-mgmt/poudriere: fix PORTCONFIG option documentation

    PR:             274433
    Reported by:    Anton Saietskii <vsasjason@gmail.com>

 ports-mgmt/poudriere/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)