Bug 274486 - deskutils/sigi: update to 3.6.3
Summary: deskutils/sigi: update to 3.6.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://github.com/sigi-cli/sigi/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-15 10:59 UTC by J.R. Hill
Modified: 2024-02-10 13:50 UTC (History)
2 users (show)

See Also:
hiljusti: maintainer-feedback+


Attachments
patch file (29.36 KB, patch)
2023-10-15 10:59 UTC, J.R. Hill
hiljusti: maintainer-approval+
Details | Diff
patch file (2) (29.40 KB, patch)
2023-10-29 05:24 UTC, J.R. Hill
hiljusti: maintainer-approval+
Details | Diff
patch file to 3.6.3 (29.36 KB, patch)
2024-02-08 06:53 UTC, J.R. Hill
hiljusti: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description J.R. Hill 2023-10-15 10:59:05 UTC
Created attachment 245632 [details]
patch file

Updating to latest version
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-10-16 05:26:06 UTC
Please avoid consecutive blank lines in port Makefiles (run portlint to spot these).

Is there a changelog for this update?

There appears to be a distinfo issue with this patch:

=> sigi-cli-sigi-v3.6.2_GH0.tar.gz doesn't seem to exist in /data/distfiles/.
=> Attempting to fetch https://codeload.github.com/sigi-cli/sigi/tar.gz/v3.6.2?dummy=/sigi-cli-sigi-v3.6.2_GH0.tar.gz
fetch: https://codeload.github.com/sigi-cli/sigi/tar.gz/v3.6.2?dummy=/sigi-cli-sigi-v3.6.2_GH0.tar.gz: size unknown
fetch: https://codeload.github.com/sigi-cli/sigi/tar.gz/v3.6.2?dummy=/sigi-cli-sigi-v3.6.2_GH0.tar.gz: size of remote file is not known
sigi-cli-sigi-v3.6.2_GH0.tar.gz                         31 kB 1962 kBps    00s
=> Fetched file size mismatch (expected 32190, actual 32215)
=> Trying next site
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/sigi-cli-sigi-v3.6.2_GH0.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/sigi-cli-sigi-v3.6.2_GH0.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this


Please check and regenerate distinfo as appropriate.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-10-28 03:17:47 UTC
No response from submitter, returning to pool.

Please address the remarks from comment #1 to get this one committed.
Comment 3 J.R. Hill 2023-10-29 05:07:57 UTC
Here's the chnagelog
Comment 4 J.R. Hill 2023-10-29 05:24:07 UTC
I removed newlines from the Makefile to get it passing `portlint -t`

Trying to figure out the distinfo error, but I can't replicate it. Aside from timestamps I get the same output no matter how many times I `make makesum`. I'm up-to-date on installations like the rust toolchain.

I'll attach the updated patchfile
Comment 5 J.R. Hill 2023-10-29 05:24:50 UTC
Created attachment 245965 [details]
patch file (2)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-10-29 07:02:45 UTC
(In reply to J.R. Hill from comment #4)

Try to remove the distfile from your disk first.  Otherwise it might not have been fetched again.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-11-21 05:34:48 UTC
Any progress on working out the distinfo issues?  If you can't fix that, please let me know.  I'll try to regenerate the distinfo myself then.
Comment 8 J.R. Hill 2023-11-21 21:44:53 UTC
Thanks for checking in -- No progress yet, I got the same output a few times and couldn't figure out if something is cached

I think I might have to setup my whole dev setup from scratch again. I don't really know what difference should look like either
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2023-11-21 22:06:07 UTC
(In reply to J.R. Hill from comment #8)

Try these steps:

 1. remove the local copy of the distfile.  To do this, run
    "make delete-distfiles" in the port directory.  If that doesn't work, go to
    the directory where the distfiles are (usually /usr/ports/distfiles) and
    manually delete the distfile.  This step is very important.
 2. Run "make makesum" again.  This downloads the distfile again and should pick
    up the new checksum.
 3. Run "git diff" to verify that distinfo has a new checksum.
 4. Resubmit your patch with the new distinfo.

There is no reason to redo your dev setup.  Everything is fine.  But: if you do not delete the existing distfile, "make makesum" will just give you the checksum of that file instead of fetching it again from the internet.
Comment 10 J.R. Hill 2024-02-08 06:53:17 UTC
Created attachment 248249 [details]
patch file to 3.6.3
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2024-02-08 11:40:22 UTC
That seems to build just fine!
Comment 12 J.R. Hill 2024-02-08 16:09:33 UTC
Thanks Robert!
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-02-10 13:48:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df4e32c9b3af97b2790f4ee8e35f0a3d1f1f2e24

commit df4e32c9b3af97b2790f4ee8e35f0a3d1f1f2e24
Author:     J.R. Hill <hiljusti@so.dang.cool>
AuthorDate: 2024-02-08 06:35:31 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-02-10 13:41:53 +0000

    deskutils/sigi: Update to 3.6.3

    Changelog: https://github.com/sigi-cli/sigi/releases/tag/v3.6.3

    PR:             274486

 deskutils/sigi/Makefile        |   4 +-
 deskutils/sigi/Makefile.crates | 107 ++++++++++----------
 deskutils/sigi/distinfo        | 220 ++++++++++++++++++++---------------------
 3 files changed, 157 insertions(+), 174 deletions(-)
Comment 14 Robert Clausecker freebsd_committer freebsd_triage 2024-02-10 13:50:41 UTC
Thank you for your contribution.