Bug 274567 - x11-wm/bspwm-devel:When using pkg to install the software, the freedesktop file was not installed
Summary: x11-wm/bspwm-devel:When using pkg to install the software, the freedesktop fi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joel Bodenmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-18 17:07 UTC by Kevin
Modified: 2023-11-30 13:19 UTC (History)
1 user (show)

See Also:
jbo: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin 2023-10-18 17:07:37 UTC
After installing bspwm-devel using PKG, I found that the display manager cannot recognize it correctly. The display manager I am using is ly. Then I found that there is no bspwm.desktop file in {STAGEDIR}${PREFIX}/share/xsessions/bspwm.desktop. 
In the end, I tried installing using port and everything was fine.
Please fix this issue as the maintainer notices it.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2023-11-28 06:30:51 UTC
^Triage: this is not about the package building machines.
Comment 2 Joel Bodenmann freebsd_committer freebsd_triage 2023-11-28 11:23:08 UTC
I assume that when you built the package yourself you enabled the CONTRIB option (default is OFF) which adds the .desktop file?

Upstream supplies the .desktop file as /contrib. I think the best course of action is to just enable the CONTRIB option by default.
I'll update the x11-wm/bspwm-devel port shortly and I'll provide the corresponding patch for x11-wm/bspwm in a separate PR.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-28 12:01:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=48282e3de092c0e8ff187579d0c9f9bbb917c43c

commit 48282e3de092c0e8ff187579d0c9f9bbb917c43c
Author:     Joel Bodenmann <jbo@FreeBSD.org>
AuthorDate: 2023-11-28 11:58:26 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2023-11-28 11:59:54 +0000

    x11-wm/bspwm-devel: Enable CONTRIB option by default

    The CONTRIB option ships a bunch of files which the average user might expect
    to just get by default (most notably a .desktop file). The .desktop file
    allows display managers following the freedesktop.org standards to discover
    bspwm automatically.

    PR:             274567
    Approved by:    zirias (mentor)

 x11-wm/bspwm-devel/Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 4 Joel Bodenmann freebsd_committer freebsd_triage 2023-11-30 13:19:37 UTC
Both the x11-wm/bspwm and the x11-wm/bspwm-devel port have been updated so that the CONTRIB option is enabled by default.

Thank you for reporting!