Bug 274681 - lang/quickjs: port should provide a shared object
Summary: lang/quickjs: port should provide a shared object
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/bellard/quickjs/is...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-23 21:03 UTC by Robert Clausecker
Modified: 2023-10-24 02:11 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
fuz: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2023-10-23 21:03:50 UTC 
The port emulators/tic-80 uses the quickjs library for javascript bindings.  However, lang/quickjs only provides static libraries.  Please adapt the port to produce a shared library so others can link with it.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-10-23 23:57:30 UTC 
I asked the upstream to create shared libraries, but I'll also patch the port to change to shared libraries in the mean time.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-10-24 00:31:04 UTC 
Change port to build shared libs.

Thanks for your request,
Yuri
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-24 00:35:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f8471874612278840b3db3076f3982cf5e259cc3

commit f8471874612278840b3db3076f3982cf5e259cc3
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-24 00:23:21 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-24 00:34:53 +0000

    lang/quickjs: Build shared libraries

    PR:             274681
    Reported by:    Robert Clausecker <fuz@FreeBSD.org>

 emulators/tic-80/Makefile               |  5 +--
 lang/quickjs/Makefile                   |  4 ++
 lang/quickjs/files/patch-Makefile (new) | 71 +++++++++++++++++++++++++++++++++
 lang/quickjs/files/patch-qjsc.c (new)   | 11 +++++
 lang/quickjs/pkg-plist                  |  2 +-
 www/edbrowse/Makefile                   |  4 +-
 www/edbrowse/files/patch-src_makefile   |  2 +-
 7 files changed, 92 insertions(+), 7 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-10-24 02:11:38 UTC 
Thank you for the quick response.  Much appreciated.