Created attachment 245858 [details] patch for crowdsec v1.5.5 Upstream release, no packaging changes except requiring Go 1.21 to build, which is not default yet.
Have you run this through poudriere-testport? It has some QA complaints about linking to devel/abseil without declaring it as a dependency.
(In reply to Joel Bodenmann from comment #1) Yes, I usually test builds for freebsd, pfsense and opnsense with poudriere overlays ( https://github.com/crowdsecurity/packaging-poudriere ) on top of the respective main ports branches. But I usually build in bulk and I see what you mean if I run testsport. There are benign errors - because requiring re2 is enough to build and link with abseil. Last I checked the dependency from re2 to abseil is quite recent and some architectures still build the old version that doesn't require it. If you think we should add devel/abseil, I'm ok with that. Thanks for the review
Generally we definitely want to ensure that poudriere-testport does not have any complains to report. It's part of the standard QA workflow similar to checking the output of portlint and portclippy. If you could update the accordingly patch that would be great.
Created attachment 246023 [details] patch for 1.5.5 with abseil dependency Patch updated! Thanks again
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6e73670a7358f25392dac5e2da7055c30532e8ee commit 6e73670a7358f25392dac5e2da7055c30532e8ee Author: Marco Mariani <marco@crowdsec.net> AuthorDate: 2023-10-24 21:50:53 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2023-11-01 14:36:03 +0000 security/crowdsec: Update to 1.5.5 PR: 274710 Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D42396 security/crowdsec/Makefile | 9 +++++---- security/crowdsec/distinfo | 10 +++++----- 2 files changed, 10 insertions(+), 9 deletions(-)
Committed - thanks!