Bug 274750 - devel/zeal Update to 0.7.0 and remove deprecation
Summary: devel/zeal Update to 0.7.0 and remove deprecation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL: https://github.com/zealdocs/zeal/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-27 08:50 UTC by Bartek Jasicki
Modified: 2023-12-04 23:02 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (rakuco)


Attachments
Update to 0.7.0 (2.50 KB, patch)
2023-10-27 08:50 UTC, Bartek Jasicki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bartek Jasicki 2023-10-27 08:50:43 UTC
Created attachment 245912 [details]
Update to 0.7.0

Update the program to version 0.7.0. This version no longer depends on the deprecated qt-webkit, but uses the maintained qt-webengine. Also, removed the unneeded patch.

Full changelog for the version: https://github.com/zealdocs/zeal/releases/tag/v0.7.0
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2023-12-02 23:06:56 UTC
Sorry for the delay here. The change looks fine, but I haven't tested it myself.

I'm assigning this to jhale@, who's expressed interest in fixing this port as well.
Comment 2 Bartek Jasicki 2023-12-03 04:22:00 UTC
(In reply to Raphael Kubo da Costa from comment #1)

Hello,

No problem. :)
I'm using it by the whole time. It seems working as good as the previous version.
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2023-12-03 05:51:02 UTC
(In reply to Bartek Jasicki from comment #2)

Would you mind if the port switched to Qt6? I didn't see this PR when I was working on the update for devel/zeal and since it builds with Qt6 by default now, I just dumped Qt5 in my patch. I could flavorize it, but since Qt5 is sort of EOL now, I didn't bother.
Comment 4 Bartek Jasicki 2023-12-03 06:36:28 UTC
(In reply to Jason E. Hale from comment #3)

I don't mind switching to Qt6. If you want to change the patch, feel free to do it. :)

I agree, there is no sense in creating flavors for the port.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-12-04 22:40:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=53c9479cc9f133ad89c2b512bf15adb2326fa307

commit 53c9479cc9f133ad89c2b512bf15adb2326fa307
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2023-12-02 17:52:57 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-12-04 22:39:26 +0000

    devel/zeal: Update to 0.7.0

    Remove DEPRECATED/EXPIRATION_DATE. Port now builds against Qt6 and
    the WebEngine module.

    Pet portlint(1) and portclippy(1).

    https://github.com/zealdocs/zeal/releases/tag/v0.7.0

    PR:             274750
    Reported by:    Bartek Jasicki <thindil@laeran.pl.eu.org>
    Approved by:    rakuco (maintainer)

 devel/zeal/Makefile                                | 28 ++++++++++------------
 devel/zeal/distinfo                                |  8 ++++---
 ...patch-src_libs_ui_searchitemdelegate.cpp (gone) | 10 --------
 devel/zeal/pkg-plist                               |  4 ++--
 4 files changed, 20 insertions(+), 30 deletions(-)
Comment 6 Jason E. Hale freebsd_committer freebsd_triage 2023-12-04 23:02:47 UTC
Thanks a lot for your report, patch and feedback, Bartek! I've updated the port to build against Qt6 and have done a little bit of clean-up. This is a cool little app and didn't want to see it zapped. I greatly appreciate the feedback from rakuco, as well.