Bug 274782 - net/libngtcp2: Update to 1.2.0
Summary: net/libngtcp2: Update to 1.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://github.com/ngtcp2/ngtcp2/rele...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-29 01:41 UTC by Daniel Engberg
Modified: 2024-02-05 23:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Patch for libngtcp (2.65 KB, patch)
2023-10-29 01:41 UTC, Daniel Engberg
no flags Details | Diff
Patch for libngtcp2 v2 (2.61 KB, patch)
2023-12-04 19:42 UTC, Daniel Engberg
no flags Details | Diff
Patch for libngtcp2 v3 (2.61 KB, patch)
2024-01-22 18:57 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-10-29 01:41:39 UTC
Created attachment 245962 [details]
Patch for libngtcp

* Switch to CMake for faster builds, it also additionally cleans up the port Makefile and removes the need for additional patching
* Remove C++17 requirement, only C++14 is required
* C++14 or C1++17 are default for all compilers we have in tree or base so no need to add CXXFLAGS
* Disable OpenSSL requirement as it fails due to lack of QUIC support which is in 3.2
* Rearrange Makefile to follow Porters Handbook more closely and for readability

Compile tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist)
Poudriere testport OK 12.4-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-12-04 19:42:37 UTC
Created attachment 246781 [details]
Patch for libngtcp2 v2
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-01-22 18:57:19 UTC
Created attachment 247853 [details]
Patch for libngtcp2 v3
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-02-05 23:33:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=513740cc8e824a4d53853a38a5470a9d3bcd6996

commit 513740cc8e824a4d53853a38a5470a9d3bcd6996
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-02-05 23:18:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-02-05 23:18:56 +0000

    net/libngtcp2: Update to 1.2.0

    * Switch to CMake for faster builds, it also additionally cleans up the
      port Makefile and removes the need for additional patching
    * Disable OpenSSL requirement as it fails due to lack of QUIC support
      which is in 3.2
    * Rearrange Makefile to follow Porters Handbook more closely and
      for readability

    PR:             274782
    Approved by:    portmgr (maintainer timeout 2+ weeks)

 net/libngtcp2/Makefile                       | 17 +++++++++--------
 net/libngtcp2/distinfo                       |  6 +++---
 net/libngtcp2/files/patch-Makefile.in (gone) | 13 -------------
 net/libngtcp2/pkg-plist                      |  2 +-
 4 files changed, 13 insertions(+), 25 deletions(-)