Bug 274789 - devel/py-pytest-xdist: Update to 3.3.1
Summary: devel/py-pytest-xdist: Update to 3.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/pytest-dev/pytest-...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-29 12:43 UTC by Kai Knoblich
Modified: 2023-11-03 16:31 UTC (History)
1 user (show)

See Also:
kai: maintainer-feedback+


Attachments
py-pytest-xdist-3.3.1.patch (2.27 KB, patch)
2023-10-29 12:43 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2023-10-29 12:43:24 UTC
Created attachment 245970 [details]
py-pytest-xdist-3.3.1.patch

Hi Moin,

attached is a patch that updates devel/py-pytest-xdist to 3.3.1 and adds the following changes to the port:

- Introduce default PSUTIL and SETPROCTITLE options to reflect the settings as noted in "pyproject.toml".
- Switch to the PEP517 build framework.
- Update test suite and use USE_PYTHON=pytest to simplify the Makefile.

The update should fix similar issues like this one (discovered during QA when running the testsuite of textproc/py-ocrmypdf):

> [...]
> INTERNALERROR>   File "/usr/local/lib/python3.9/site-packages/xdist/scheduler/each.py", line 1, in <module>
> INTERNALERROR>     from py.log import Producer
> INTERNALERROR> ModuleNotFoundError: No module named 'py.log'; 'py' is not a package
> [...]

This is because devel/py-py was removed from devel/py-pytest's RUN_DEPENDS in ports 47177a522b37 as it's no longer a dependency since 7.2.0.


QA:
~~~
poudriere -> OK (12.4-RELEASE amd64 for py38, py39, py310 and py311)


Results of 'make test' (for py38 - py311):
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> == 187 passed, 5 skipped, 11 xfailed in NN.NNs ==
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-10-29 12:49:03 UTC
Can you test this on 13.2 and 14.0? If it builds ok please feel free to push. Otherwise let me know, will put it on tonight's build queue.
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2023-10-29 13:09:04 UTC
(In reply to Muhammad Moinur Rahman from comment #1)

Thanks for your swift reply and sure, I can test it on 13.2 and 14.0, as well. But it will take a bit more time and I'm going to post here the results, once the builds are complete.
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-10-29 13:10:38 UTC
I trust you with the results. If it builds fine just ship it. :P
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2023-10-29 13:19:21 UTC
(In reply to Muhammad Moinur Rahman from comment #3)

Thanks, alright, then I'll shepherd the update into the ports tree. :)

ETA: Either this afternoon or the next 1-2 days.


^Triage: Set maintainer-feedback flag to '+' as maintainer feedback was given.
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2023-10-29 14:29:20 UTC
Comment on attachment 245970 [details]
py-pytest-xdist-3.3.1.patch

Builds on 13.2-RELEASE amd64 + 14.0-RC3 are fine. The results of the test suite are similar as noted in comment #0.

^Triage: Setting maintainer-approval flag accordingly.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-29 14:41:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5f7e3b0145f8104e480f5f99fd61dd61c49039bd

commit 5f7e3b0145f8104e480f5f99fd61dd61c49039bd
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2023-10-29 14:34:52 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2023-10-29 14:34:52 +0000

    devel/py-pytest-xdist: Update to 3.3.1

    * Introduce default PSUTIL and SETPROCTITLE options to reflect the
      settings as noted in "pyproject.toml".

    * Switch to the PEP517 build framework.

    * Update test suite and use USE_PYTHON=pytest to simplify the Makefile.

    * Errors like this one [1] should be remedied with this update:

    [...]
    INTERNALERROR>   File "/usr/local/lib/python3.9/site-packages/xdist/scheduler/each.py", line 1, in <module>
    INTERNALERROR>     from py.log import Producer
    INTERNALERROR> ModuleNotFoundError: No module named 'py.log'; 'py' is not a package
    [...]

      This is because devel/py-py was removed from devel/py-pytest's
      RUN_DEPENDS in 47177a522b37 as it's no longer a dependency since
      py-pytest 7.2.0.

    Changelog since 2.5.0:

    https://github.com/pytest-dev/pytest-xdist/blob/v3.3.1/CHANGELOG.rst

    PR:             274789
    Reported by:    QA run of textproc/py-ocrmypdf's test suite [1]
    Approved by:    bofh (maintainer)

 devel/py-pytest-xdist/Makefile | 21 ++++++++++++++-------
 devel/py-pytest-xdist/distinfo |  6 +++---
 2 files changed, 17 insertions(+), 10 deletions(-)
Comment 7 Kai Knoblich freebsd_committer freebsd_triage 2023-10-29 14:42:36 UTC
(In reply to Muhammad Moinur Rahman from comment #3)

Committed, thanks for your feedback. I'll leave this bug open for reference for a few days.
Comment 8 Kai Knoblich freebsd_committer freebsd_triage 2023-11-03 16:31:04 UTC
No issues so far, so this bug is now closed.