Bug 274819 - net/miniupnpd: use libpfctl
Summary: net/miniupnpd: use libpfctl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kristof Provost
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-30 20:11 UTC by Kristof Provost
Modified: 2023-11-13 20:00 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (squat)

Attachments
0001-net-miniupnpd-use-libpfctl.patch (18.98 KB, text/plain)
2023-10-30 20:11 UTC, Kristof Provost 		no flags Details
0001-net-miniupnpd-use-libpfctl.patch (18.95 KB, patch)
2023-10-31 20:10 UTC, Kristof Provost 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristof Provost freebsd_committer freebsd_triage 2023-10-30 20:11:18 UTC 
Created attachment 246004 [details]
0001-net-miniupnpd-use-libpfctl.patch

Here's a patch to make miniupnpd use libpfctl. That avoids the use of DIOCGETSTATUS and DIOCGETRULE, which have been removed in main (15).

In other words: this patch is required to use miniupnpd on modern FreeBSD.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-10-30 21:14:04 UTC 
Can you please submit it upstream Kristof?
Comment 2 Kristof Provost freebsd_committer freebsd_triage 2023-10-31 09:18:39 UTC 
https://github.com/miniupnp/miniupnp/pull/671

In the mean time we really should include this patch in the freebsd ports tree, because miniupnpd is broken on main and has been since August.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-10-31 16:58:52 UTC 
Thanks, only "nitpick" I have is that we use you USES= localbase:ldflags instead of adding things to C/LDFLAGS
Comment 4 Kristof Provost freebsd_committer freebsd_triage 2023-10-31 20:10:11 UTC 
Created attachment 246028 [details]
0001-net-miniupnpd-use-libpfctl.patch
Comment 5 Kristof Provost freebsd_committer freebsd_triage 2023-11-06 09:54:49 UTC 
Ping?

Is anything blocking this patch?
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-11-10 00:03:47 UTC 
We'll have to wait for 14 days to give the maintainer a chance to respond.  You can commit with "maintainer timeout" next Monday if there's no maintainer response until then (I approve for ports).
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-11-13 09:40:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=81e8bb983432251d47c3447bf6c1572fa0a84501

commit 81e8bb983432251d47c3447bf6c1572fa0a84501
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2023-10-30 16:23:10 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-11-13 09:39:43 +0000

    net/miniupnpd: use libpfctl

    Start using libpfctl to replace the removed ioctl calls (DIOCGETSTATUS,
    DIOCGETRULE).

    PR:             274819
    Approved by:    maintainer timeout
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 net/miniupnpd/Makefile                         |   8 +-
 net/miniupnpd/files/patch-pf_obsdrdr.c (new)   | 368 +++++++++++++++++++++++++
 net/miniupnpd/files/patch-pf_pfpinhole.c (new) | 160 +++++++++++
 3 files changed, 533 insertions(+), 3 deletions(-)