Bug 275076 - devel/cunit: broken plist
Summary: devel/cunit: broken plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-14 12:39 UTC by Dmitry Marakasov
Modified: 2023-11-27 10:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2023-11-14 12:39:39 UTC 
cunit fails with some options configurations:

SUCCESS devel/cunit on 13-amd64, log: /reprise/logs/1857
BLDFAIL devel/cunit on 13-amd64 (-AUTOMATED), log: /reprise/logs/1858
BLDFAIL devel/cunit on 13-amd64 (-BASIC), log: /reprise/logs/1859
BLDFAIL devel/cunit on 13-amd64 (-CONSOLE), log: /reprise/logs/1860
BLDFAIL devel/cunit on 13-amd64 (-CURSES), log: /reprise/logs/1861
SUCCESS devel/cunit on 13-amd64 (-DEBUG), log: /reprise/logs/1862
SUCCESS devel/cunit on 13-amd64 (-DOCS), log: /reprise/logs/1863
SUCCESS devel/cunit on 13-amd64 (-EXAMPLES), log: /reprise/logs/1864
SUCCESS devel/cunit on 13-amd64 (-MEMTRACE), log: /reprise/logs/1865
BLDFAIL devel/cunit on 13-amd64 (-TEST), log: /reprise/logs/1866

In all cases, plist is incorrect.

-AUTOMATED:
Error: Missing: %%EXAMPLESDIR%%/Automated/AutomatedTest
Error: Missing: %%EXAMPLESDIR%%/Automated/README

-BASIC:
Error: Missing: %%EXAMPLESDIR%%/Basic/BasicTest
Error: Missing: %%EXAMPLESDIR%%/Basic/README

-CONSOLE:
Error: Missing: %%EXAMPLESDIR%%/Console/ConsoleTest
Error: Missing: %%EXAMPLESDIR%%/Console/README

-CURSES:
Error: Missing: %%EXAMPLESDIR%%/Curses/CursesTest
Error: Missing: %%EXAMPLESDIR%%/Curses/README

-TEST:
Error: Missing: %%DATADIR%%/Test/test_cunit

I suggest to remove most options from this port, as these do not bring and noticeable build time or package size improvements, and do not brong additional dependencies. This would simplify both both, plist and user experience.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-27 10:46:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3bd59faafb0cfcbe50fe735b7347e2ac55c97d9

commit c3bd59faafb0cfcbe50fe735b7347e2ac55c97d9
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-11-27 10:23:46 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-11-27 10:30:09 +0000

    devel/cunit: Remove AUTOMATED, BASIC, CONSOLE, CURSES, DEBUG, MEMTRACE and TEST options

    PR:             275076
    Reported by:    amdmi3

 devel/cunit/Makefile  | 27 +++++----------------------
 devel/cunit/pkg-plist |  8 ++++----
 2 files changed, 9 insertions(+), 26 deletions(-)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-11-27 10:48:16 UTC 
Committed. Thanks!