Bug 275128 - sysutils/jdupes: Update to 1.27.3_1
Summary: sysutils/jdupes: Update to 1.27.3_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://www.jdupes.com/2023/11/10/new...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-16 13:50 UTC by Thomas Hurst
Modified: 2023-11-17 18:30 UTC (History)
1 user (show)

See Also:
fernape: merge-quarterly+

Attachments
Git patch for sysutils/jdupes (5.07 KB, patch)
2023-11-16 13:50 UTC, Thomas Hurst 		tom: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hurst 2023-11-16 13:50:36 UTC 
Created attachment 246350 [details]
Git patch for sysutils/jdupes

Apply a fix for the jdupes hash database feature to avoid potential
database loss, resulting from disk-full situations and other write
failures.

Obtained from: https://www.jdupes.com/2023/11/10/news-fix-for-v1-27-3-libjodycode-4-work/
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-17 07:30:42 UTC 
Important to merge to 2023Q4?
Comment 2 Thomas Hurst 2023-11-17 13:38:20 UTC 
I'd lean towards yes. The maintainer evidently found it important enough to backport, and directly ask maintainers to apply it, having experienced the issue themselves.

Losing the database is more an annoyance than anything - you can always just regenerate it, but that is likely to be an expensive operation given what the tool/feature is for.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-17 18:28:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=efcf734590eaaf1dee0bac5fc758680925501d15

commit efcf734590eaaf1dee0bac5fc758680925501d15
Author:     Thomas Hurst <tom@hur.st>
AuthorDate: 2023-11-17 07:30:06 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-11-17 18:28:15 +0000

    sysutils/jdupes: Update to 1.27.3_1

    ChangeLog:
    https://www.jdupes.com/2023/11/10/news-fix-for-v1-27-3-libjodycode-4-work/

    Apply a fix for the jdupes hash database feature to avoid potential
    database loss, resulting from disk-full situations and other write
    failures.

    PR:             275128
    Reported by:    tom@hur.st (maintainer)
    MFH:            2023Q4 (bugfix)

 sysutils/jdupes/Makefile                   |   1 +
 sysutils/jdupes/files/patch-hashdb.c (new) | 114 +++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+)
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-17 18:30:19 UTC 
Committed and merged to 2023Q4.

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-11-17 18:30:50 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=91b52f2c0fd09ef333fe1a2ac1f0ce5f27d9b741

commit 91b52f2c0fd09ef333fe1a2ac1f0ce5f27d9b741
Author:     Thomas Hurst <tom@hur.st>
AuthorDate: 2023-11-17 07:30:06 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-11-17 18:29:23 +0000

    sysutils/jdupes: Update to 1.27.3_1

    ChangeLog:
    https://www.jdupes.com/2023/11/10/news-fix-for-v1-27-3-libjodycode-4-work/

    Apply a fix for the jdupes hash database feature to avoid potential
    database loss, resulting from disk-full situations and other write
    failures.

    PR:             275128
    Reported by:    tom@hur.st (maintainer)
    MFH:            2023Q4 (bugfix)

    (cherry picked from commit efcf734590eaaf1dee0bac5fc758680925501d15)

 sysutils/jdupes/Makefile                   |   1 +
 sysutils/jdupes/files/patch-hashdb.c (new) | 114 +++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+)