Bug 275130 - net-mgmt/librenms: should drag php*-iconv as a dependency
Summary: net-mgmt/librenms: should drag php*-iconv as a dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-16 16:49 UTC by Francis GUDIN
Modified: 2023-11-16 20:48 UTC (History)
0 users

See Also:
dvl: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francis GUDIN 2023-11-16 16:49:32 UTC 
Hello,

when dealing with non-UTF8 hosts, the inferEncoding from LibreNMS/Util/StringHelpers.php requires an iconv().

The following should unconditionally require php’s iconv port and make LibreNMS more useful:

--- Makefile.orig       2023-11-16 17:42:36.878650000 +0100
+++ Makefile    2023-11-16 17:42:47.428651000 +0100
@@ -27,7 +27,7 @@

 USES=          cpe php python shebangfix
 USE_GITHUB=    yes
-USE_PHP=       ctype curl dom fileinfo filter gd hash json ldap mbstring \
+USE_PHP=       ctype curl dom fileinfo filter gd hash iconv json ldap mbstring \
                mysqli openssl pdo pdo_mysql phar posix session simplexml snmp \
                sockets tokenizer xml xmlwriter zip
 USE_RC_SUBR=   librenms

Thanks in advance,
-- 
Francis GUDIN
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-16 20:41:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=787fe89073b39ca8c225bf947969627fdced817d

commit 787fe89073b39ca8c225bf947969627fdced817d
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2023-11-16 20:39:40 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2023-11-16 20:41:03 +0000

    net-mgmt/librenms: add missing dependency: iconv

    While here, run portfmt.
    PR:             275130

 net-mgmt/librenms/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Comment 2 Dan Langille freebsd_committer freebsd_triage 2023-11-16 20:48:02 UTC 
Thank you