Bug 275161 - www/nginx{,-full,-devel} failing when PASSENGER module is compiled, includes patch
Summary: www/nginx{,-full,-devel} failing when PASSENGER module is compiled, includes ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords:
: 273930 (view as bug list)
Depends on:
Blocks: 275262
  Show dependency tree / graph
 
Reported: 2023-11-18 10:27 UTC by pr
Modified: 2023-12-03 09:58 UTC (History)
6 users (show)

See Also:

Attachments
Forcing C++14 code when compiling PASSENGER module (934 bytes, patch)
2023-11-18 10:27 UTC, pr 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pr 2023-11-18 10:27:59 UTC 
Created attachment 246386 [details]
Forcing C++14 code when compiling PASSENGER module

As reported https://lists.freebsd.org/archives/freebsd-ports/2023-July/004203.html www/nginx and www/nginx-devel fail to compile when PASSENGER module is enabled.

Passenger code is C++14 and current compiler assumes C++17 by default.

The suggested patch fixes the problem by forcing C++14 code when compiling the module.

Poudriere tested under 13.2 and 14.0.
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2023-11-22 14:56:01 UTC 
This is identical to bug 273930.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2023-11-22 15:03:29 UTC 
*** Bug 273930 has been marked as a duplicate of this bug. ***
Comment 3 Dan Langille freebsd_committer freebsd_triage 2023-12-01 21:13:24 UTC 
This just hit me today, while building for FreeBSD 14.0

Any reason not to commit it?
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-12-01 21:20:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=397e97bec614388c452a1db5c69138d54655911c

commit 397e97bec614388c452a1db5c69138d54655911c
Author:     Sergey A. Osokin <osa@FreeBSD.org>
AuthorDate: 2023-12-01 21:18:17 +0000
Commit:     Sergey A. Osokin <osa@FreeBSD.org>
CommitDate: 2023-12-01 21:19:30 +0000

    www/nginx-devel: fix build with a third-party passenger module

    Bump PORTREVISION.

    PR:     275161

 www/nginx-devel/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2023-12-02 07:24:02 UTC 
I'm going to take this after maintainer timeout. Hold on.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-12-03 07:53:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b31426d1f77c12e47a60ff4b6b663826afd4702f

commit b31426d1f77c12e47a60ff4b6b663826afd4702f
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2023-12-03 07:51:41 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2023-12-03 07:52:46 +0000

    www/nginx: fix build with a third-party passenger module

    PR:     275161
    Sponsored by:   Netzkommune GmbH

 www/nginx/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-12-03 09:58:43 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8848573087ff210c5383adcd899b055c50467fb4

commit 8848573087ff210c5383adcd899b055c50467fb4
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2023-12-03 07:51:41 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-12-03 09:57:04 +0000

    www/nginx: fix build with a third-party passenger module

    PR:     275161
    Sponsored by:   Netzkommune GmbH

    This commit is required to complete PR 275161. The fix for
    www/nginx-devel is not necessary at the moment.

    (cherry picked from commit b31426d1f77c12e47a60ff4b6b663826afd4702f)

 www/nginx/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)