Created attachment 246406 [details] git format-patch -1 main - update 4.33 -> 4.34 https://metacpan.org/release/MLEHMANN/EV-4.34/source/Changes - "portlint -AC gives non-relevant warn. - "portclippy Makefile" is happy. - "portfmt -D Makefile" is happy. - Tested with: 14.0-RELEASE portlint 2.21.0 portfmt 1.1.5 pkg 1.20.990.8 poudriere-git-3.4.99.20231113 perl 5.36.1_1 ssl=base - built-in perl tests in a clean poudriere jail say: PASS.
Thank you for you work! Can I ask about p5-Canary-Stability? As I can see it only required at configure time, but you added it to RUN_DEPENDS. Why?
Once I made a big distillation of RUN_ from BUILD_DEPENDS in a number of my perl ports. It caused a strong reprimand and revert of commits from sunpoet@ (with perl@ hat on) who said, it is a long lasting rule for all perl ports to have identical RUN_ and BUILD_DEPENDS.
(In reply to Sergei Vyshenski from comment #2) sunpoet@, sorry to bother, but can you please comment on this? In this module p5-Canary-Stability used only in Makefile.PL while configuring. After install, port not depends on it anymore. Also I see p5-GD, where BUILD_DEPENDS clearly not equal to RUN_DEPENDS (see bug #235593)...
Sorry for misleading you. It was not sunpoet@, but Frederic Culot <culot@FreeBSD.org> instead, then a portmgr secretary. We had a private discussion concerning a PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192741 Here is copy of Frederic's e-mail of 18 Aug 2014: ====================================== Hi Serge, > > Hi Frederic, > > Thank you so much for taking care about my PR. and thanks to you for submitting it 🙂 > > What is the philosophy for always setting the following? : > > RUN_DEPENDS:= ${BUILD_DEPENDS} > > I was so happy when I discovered, that I can decouple them from one another. > Sure all on them are not needed during build stage. Just perl is needed, but > it is covered by You are right, but for perl ports it became usual to define all dependencies in BUILD_DEPENDS and then to assign the run dependencies using the construct above. This is just to avoid warnings when the configure script checks for dependencies' presence (the "Checking if your kit is complete..." step). As the dependencies will be installed anyway it was decided to declare them preferably in BUILD_DEPENDS so that the end user does not get scared by warning messages about missing dependencies at build time. I hope this explains a bit Serge, otherwise feel free to contact me again! Cheers, Frederic ================================
(In reply to Sergei Vyshenski from comment #4) Hi! Sure, it is correct sentence that RUN_DEPENDS in most cases can safely be added to BUILD_DEPENDS. Moreover for pure perl modules configure/build step is so thin that rarely any additional build-only deps ever required (except ExtUtils::MakeMaker/Module::Build which added semi-automatically and in most cases just check requirements and copy files to destination). But! :-) 1. This port is not pure perl software, this is fullfeatured C library which requires C toolchain to be built (with all sorts of required configuration steps). 2. This is not about adding RUN_DEPENDS to BUILD_DEPENDS, but opposite... Why we ever need to setup things that only required at build step? I still don't understand ) Can I ask to return to current state of dependencies until more strong arguments will emerge?
Created attachment 246430 [details] git format-patch -1 main
Comment on attachment 246430 [details] git format-patch -1 main Approved, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c783b2f0feae3a3fdbf1c5837868d5f10196adf8 commit c783b2f0feae3a3fdbf1c5837868d5f10196adf8 Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2023-11-19 20:07:27 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-11-24 06:12:32 +0000 devel/p5-EV: Update to 4.34 Changelog: https://metacpan.org/release/MLEHMANN/EV-4.34/source/Changes PR: 275183 Approved by: vovkasm@gmail.com (maintainer) devel/p5-EV/Makefile | 6 +++--- devel/p5-EV/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
Thank you for your contribution.