Bug 275185 - dns/renewck: Fix duplicate "-d" short cmdline option
Summary: dns/renewck: Fix duplicate "-d" short cmdline option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-18 20:55 UTC by George L. Yermulnik
Modified: 2023-11-24 11:49 UTC (History)
1 user (show)

See Also:

Attachments
Patch for dns/renewck (add patch and bump port revision) (948 bytes, patch)
2023-11-18 20:55 UTC, George L. Yermulnik 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George L. Yermulnik 2023-11-18 20:55:22 UTC 
Created attachment 246408 [details]
Patch for dns/renewck (add patch and bump port revision)

This patch fixes `Duplicate specification "domain|d:s" for option "d"` error.
The fix was provided by `renewck` author: Sergey Poznyakoff <gray@gnu.org.ua>
Quoting original email text from Sergey:
> Thanks for reporting that.  What happens is that the code defined short
> option -d equivalent to two different long options: --debug (line 421)
> and --domain (line 440).  The warning you get just draws attention
> to the fact (apparently it is reported by newer versions of
> Getopt::Long).  Please find attached a patch that fixes it.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-11-20 07:26:36 UTC 
Thank you for the update.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-24 06:16:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=373bf47474504aecaa2d56a29d7a874f1d88d81b

commit 373bf47474504aecaa2d56a29d7a874f1d88d81b
Author:     George L. Yermulnik <yz@yz.kiev.ua>
AuthorDate: 2023-11-20 07:26:04 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-24 06:12:32 +0000

    dns/renewck: Fix duplicate "-d" short cmdline option

    This patch fixes `Duplicate specification "domain|d:s" for option "d"` error.
    The fix was provided by `renewck` author: Sergey Poznyakoff <gray@gnu.org.ua>
    Quoting original email text from Sergey:
    > Thanks for reporting that.  What happens is that the code defined short
    > option -d equivalent to two different long options: --debug (line 421)
    > and --domain (line 440).  The warning you get just draws attention
    > to the fact (apparently it is reported by newer versions of
    > Getopt::Long).  Please find attached a patch that fixes it.

    PR:             275185

 dns/renewck/Makefile                  |  3 ++-
 dns/renewck/files/patch-renewck (new) | 11 +++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-11-24 06:23:26 UTC 
Thank you for your contribution.
Comment 4 George L. Yermulnik 2023-11-24 11:49:02 UTC 
Cheers Robert. Thank you too.