Bug 275196 - www/yt-dlp: allow building without py-SecretStorage
Summary: www/yt-dlp: allow building without py-SecretStorage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-19 12:18 UTC by Helge Oldach
Modified: 2023-11-19 18:34 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Unfortunately py-SecretStorage pulls in a huge dependency list including rust but actually it's optional to yt-dlp. Please see https://github.com/yt-dlp/yt-dlp/pull/8585. Lets add an OPTION for that. (1.52 KB, patch)
2023-11-19 12:18 UTC, Helge Oldach
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2023-11-19 12:18:39 UTC
Created attachment 246417 [details]
Unfortunately py-SecretStorage pulls in a huge dependency list including rust but actually it's optional to yt-dlp. Please see https://github.com/yt-dlp/yt-dlp/pull/8585. Lets add an OPTION for that.
Comment 1 Helge Oldach 2023-11-19 12:19:01 UTC
Unfortunately py-SecretStorage pulls in a huge dependency list including rust but actually it's optional to yt-dlp. Please see https://github.com/yt-dlp/yt-dlp/pull/8585. Lets add an OPTION for that.
Comment 2 Benjamin Takacs 2023-11-19 13:21:40 UTC
The option description should help the user decide if they want that option, so it should tell the user what having that optional dependency provides, not what is done on the port level.

Also the upstream default seems to be to depend on it, so it probably should be a port default, additionally having it as default avoids behaviour changes with the defaults.
Comment 3 Helge Oldach 2023-11-19 14:11:38 UTC
(In reply to Benjamin Takacs from comment #2)
Be my guest and modify.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2023-11-19 18:34:18 UTC
A modified patch was committed.

Thanks for the patch!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-11-19 18:34:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=57a397e0a279cdb6e73a29d23e233051441d179c

commit 57a397e0a279cdb6e73a29d23e233051441d179c
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-11-19 18:31:25 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-11-19 18:33:55 +0000

    www/yt-dlp: Make py-SecretStorage an optional port dependency

    py-SecretStorage pulls a lot of dependencies for a small
    optional feature in yt-dlp.

    The upstream merged the PR that also makes SecretStorage optional:
    https://github.com/yt-dlp/yt-dlp/pull/8585

    PR:             275196
    Submitted by:   Helge Oldach <freebsd@oldach.net> (initial version)

 www/yt-dlp/Makefile | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)