Bug 275212 - devel/py-diskcache: Switch to Django 4.2 and update test suite
Summary: devel/py-diskcache: Switch to Django 4.2 and update test suite
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-20 12:07 UTC by Kai Knoblich
Modified: 2023-12-08 09:51 UTC (History)
1 user (show)

See Also:
kai: maintainer-feedback-


Attachments
py-diskcache-switch-to-django42.patch (1.04 KB, patch)
2023-11-20 12:07 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2023-11-20 12:07:14 UTC
Created attachment 246445 [details]
py-diskcache-switch-to-django42.patch

Hi Yuri,

attached is a patch that switches devel/py-diskcache from Django 4.1, which will become EoL at 2023-12-31, over to Django 4.2.

The patch also updates the test suite and converts it to USE_PYTHON=pytest. 

Altough devel/py-tox is defined in the setup.py using devel/py-pytest as the latter one uses the native system environment with its installed Python packages/libaries.

QA:
~~~
poudriere -> OK (12.4-RELEASE amd64 for py39)


Results of 'make test' (for py39):
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> === 248 passed, 1 warning in NN.NNs ===
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2023-12-08 09:41:19 UTC
Comment on attachment 246445 [details]
py-diskcache-switch-to-django42.patch

^Triage: Set maintainer-approval flag to '+' due maintainer's timeout.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-08 09:51:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0d92723c069066b4c4a5d23ab74b61d2dc8f9f7e

commit 0d92723c069066b4c4a5d23ab74b61d2dc8f9f7e
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2023-12-08 09:42:47 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2023-12-08 09:49:58 +0000

    devel/py-diskcache: Switch to Django 4.2

    * Django 4.1 reaches its End-of-Life at 2023-12-31 thus switch to
      Django 4.2 which has long-term support.

    * Update test suite as well and switch to USE_PYTHON=pytest.

      Although devel/py-tox is specified in "setup.py" for the test suite,
      the use of pytest (or unittest) in terms of FreeBSD ports on
      downstream side makes more sense and give better results.

      This is because the tests are carried out within the native system
      environment and are therefore also tested against the Python version
      and packages/ports that are actually installed.

    * Bump PORTREVISION due changed dependencies.

    PR:             275212
    Approved by:    maintainer timeout (2+ weeks)

 devel/py-diskcache/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)