Bug 275240 - sysutils/limine: Update to 5.20231121.0
Summary: sysutils/limine: Update to 5.20231121.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-21 18:56 UTC by mintsuki
Modified: 2023-11-24 06:20 UTC (History)
1 user (show)

See Also:


Attachments
Upgrade patch (1.22 KB, patch)
2023-11-21 18:56 UTC, mintsuki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mintsuki 2023-11-21 18:56:08 UTC
Created attachment 246471 [details]
Upgrade patch

This patch upgrades the Limine bootloader to the latest version: 5.20231121.0.

Changelog file can be found at https://github.com/limine-bootloader/limine/releases/download/v5.20231121.0/ChangeLog
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-11-22 08:37:38 UTC
That changelog is just a list of git commits without time stamps or any information as to what versions the commits correspond to.  It's pretty much useless any I will not include it in the commit message.  It's literally worse than just linking the auto-generated

    https://github.com/limine-bootloader/limine/compare/v5.20231114.1...v5.20231121.0

It would be better if there was an actual changelog, summarising the changes that took place so it's easy to see if there's anything to pay attention to.  Yes, this is something I'm asking you (or more specifically, the upstream) to write.  It cannot be auto-generated.

If you attempt to generate a changelog automatically anyway (which I strongly recommend against as that's not particularly helpful), at least take the courtesy and produce it in such a way that it's easy to see which version corresponds to which commit.  E.g. you can do "git log --oneline <previous tag>..<this tag>" to generate a log of changes since the previous tag and includes any tags that exist so it's easy to see which commits correspond to what.
Comment 2 mintsuki 2023-11-22 10:01:58 UTC
(In reply to Robert Clausecker from comment #1)

>That changelog is just a list of git commits without time stamps or any information as to what versions the commits correspond to.

...but it does have information about which commit corresponds to a given tag.

(tag: <which tag>) <commit message>
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-11-22 17:57:04 UTC
(In reply to mintsuki from comment #2)

I see.  The changelog is so hard to read, I missed that when I had a look at it.

It's still not very useful as the commits do not tell you what changed for the user or the distribution that ships the port.  A changelog (or release notes notes) is supposed to aid the user in being aware of things that changed.  A list of commits does not fullfil this need very well.
Comment 4 mintsuki 2023-11-22 22:07:54 UTC
(In reply to Robert Clausecker from comment #3)

Alright I see. Starting from the next release I will add a manually maintained ChangeLog which hopefully resolves this request once and for all. For this release this will have to do, sorry.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-11-22 22:25:33 UTC
(In reply to mintsuki from comment #4)

Looking forwards to that!  Thank you for your work on this software.
Comment 6 mintsuki 2023-11-23 02:52:55 UTC
(In reply to Robert Clausecker from comment #5)

No problem, sorry for the inconvenience once again.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-11-24 06:16:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0fb9557d0e5ad7f138898157870d166aa8bc8c35

commit 0fb9557d0e5ad7f138898157870d166aa8bc8c35
Author:     mintsuki <mintsuki@protonmail.com>
AuthorDate: 2023-11-21 18:50:58 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-24 06:12:41 +0000

    sysutils/limine: Update to 5.20231121.0

    Changelog: https://github.com/limine-bootloader/limine/compare/v5.20231114.1...v5.20231121.0

    PR:             275240

 sysutils/limine/Makefile | 2 +-
 sysutils/limine/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-11-24 06:20:48 UTC
Thank you for your contribution.