Bug 275429 - www/mod_umask: fix for FreeBSD 14+
Summary: www/mod_umask: fix for FreeBSD 14+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-29 16:20 UTC by gebhart
Modified: 2023-11-29 18:25 UTC (History)
1 user (show)

See Also:


Attachments
patch for port in FreeBSD 14+ (1.08 KB, patch)
2023-11-29 16:20 UTC, gebhart
no flags Details | Diff
removal of FreeBSD 14 restriction in Makefile (659 bytes, patch)
2023-11-29 16:33 UTC, gebhart
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gebhart 2023-11-29 16:20:04 UTC
Created attachment 246660 [details]
patch for port in FreeBSD 14+

due to more strict type checks, the attached patch is necessary for FreeBSD 14 and above to build the module. I hope I did it right with as git patch (was my first time patching with git).
Please commit to the ports tree if ok.
Comment 1 gebhart 2023-11-29 16:26:14 UTC
I'm the maintainer btw. The Porter's handbook says I should specify Class as maintainer-update but I don't see a field flag like that here.
Comment 2 gebhart 2023-11-29 16:33:12 UTC
Created attachment 246664 [details]
removal of FreeBSD 14 restriction in Makefile

Additional patch for fixing the Makefile by removing the FreeBSD14 BROKEN
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-29 18:22:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fc1d174e5cec8f1699f840d0216868da658aa30a

commit fc1d174e5cec8f1699f840d0216868da658aa30a
Author:     Ralf Gebhart <gebhart@secnetix.de>
AuthorDate: 2023-11-29 18:18:35 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2023-11-29 18:20:48 +0000

    www/mod_umask: Fix build on FreeBSD 14+

    PR:             275429

 www/mod_umask/Makefile                           |  5 ++---
 www/mod_umask/files/patch-src_mod__umask.c (new) | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-29 18:22:02 UTC
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9f53b59852b612bc776ff814fc934f142ec72a97

commit 9f53b59852b612bc776ff814fc934f142ec72a97
Author:     Ralf Gebhart <gebhart@secnetix.de>
AuthorDate: 2023-11-29 18:18:35 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2023-11-29 18:21:10 +0000

    www/mod_umask: Fix build on FreeBSD 14+

    PR:             275429
    (cherry picked from commit fc1d174e5cec8f1699f840d0216868da658aa30a)

 www/mod_umask/Makefile                           |  5 ++---
 www/mod_umask/files/patch-src_mod__umask.c (new) | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 3 deletions(-)