Bug 275461 - net/py-maxminddb: update to 2.5.1
Summary: net/py-maxminddb: update to 2.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-30 22:21 UTC by R. Christian McDonald
Modified: 2023-12-02 01:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (olivier)


Attachments
net/py-maxminddb: update to 2.5.1 (1.69 KB, patch)
2023-11-30 22:21 UTC, R. Christian McDonald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R. Christian McDonald freebsd_committer freebsd_triage 2023-11-30 22:21:27 UTC
Created attachment 246706 [details]
net/py-maxminddb: update to 2.5.1
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2023-12-01 22:42:51 UTC
Thanks for your patch, but did you test it ?

You should test to build them with a "poudriere testport"
Usually I'm testing using 2 differents poudriere jail:
1. oldest supported FreeBSD release with i386 arch
2. head on amd64

It will give this result:

poudriere testport -j head -c net/py-maxminddb
(etc.)
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 7, in <module>
    from wheel.bdist_wheel import bdist_wheel
ModuleNotFoundError: No module named 'wheel'
*** Error code 1

Stop.


It needs a new build dependency since this commit:
https://github.com/maxmind/MaxMind-DB-Reader-python/commit/10759e205ba9c50d989dc7cc3fd14eccff27ae1c

But once fixed, there is a second update to do:

/usr/bin/strip /wrkdirs/usr/ports/net/py-maxminddb/work-py39/stage/usr/local/lib/python3.9/site-packages/maxminddb/extension*.so
strip: open /wrkdirs/usr/ports/net/py-maxminddb/work-py39/stage/usr/local/lib/python3.9/site-packages/maxminddb/extension*.so failed: No such file or directory
*** Error code 1

I will fix it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-01 22:46:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d93660647173b50ac1effe9a6db314958d812e36

commit d93660647173b50ac1effe9a6db314958d812e36
Author:     R. Christian McDonald <rcm@FreeBSD.org>
AuthorDate: 2023-11-30 22:19:23 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2023-12-01 22:45:37 +0000

    net/py-maxminddb: update to v2.5.1

    ChangeLogs:
    https://github.com/maxmind/MaxMind-DB-Reader-python/releases/tag/v2.5.0
    https://github.com/maxmind/MaxMind-DB-Reader-python/releases/tag/v2.5.1

    PR:             275461
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 net/py-maxminddb/Makefile | 7 ++-----
 net/py-maxminddb/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 8 deletions(-)
Comment 3 R. Christian McDonald freebsd_committer freebsd_triage 2023-12-02 01:06:05 UTC
huh that is weird. Not sure what happened there. I usually do a poudriere testport so I'm not sure how I missed that. My apologies. Thanks for catching my mistake!