Created attachment 246906 [details] patch to upgrade Release of Krill 0.14.3 ‘Temp’. This release fixes a number of issues found in 0.14.0 through 0.14.2: - Use rpki-rs 0.18.0 to support builds on more platforms #1166 - Fix aspa migration issues #1163 - Depend on kvx 0.9.2 to ensure temp files are used properly #1160 Most importantly, Krill will now use temp files for all data that it stores to avoid issues with half-written files in case the disk is full, or the server is rebooted in the middle of writing. This issue was introduced in release 0.14.0, and we recommend that all users upgrade to this version to avoid issues. This release also includes: - Updated German UI translations NLnetLabs/krill-ui#51
Basic Workflow when submitting git-formatted patch from next time which makes our life easier: 1. Use `git config --add core.hooksPath .hooks` to use the pre-formatted git commit message 2. Create the bug with synopsis and description but without the patch 3. Prepare the commit-msg with PR: <BUGZILLA PR> and Approved-by: submitter is maintainer 4. Add Changelog: <URL> if available in the commit message 5. Attach patch
Is there any known corner cases when stripping the binary might create problems? Warning: 'bin/krillta' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
(In reply to Muhammad Moinur Rahman from comment #2) It's no problem to strip the binary. Apparently, nobody noticed that it wasn't. A ${STRIP_CMD} should be added to the post-install target in the Makefile
Thanks. Will add accordingly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=759aafff6252fd6a3db9f3077d3c454b469beeb1 commit 759aafff6252fd6a3db9f3077d3c454b469beeb1 Author: Jaap Akkerhuis <jaap@NLnetLabs.nl> AuthorDate: 2023-12-08 17:30:04 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2023-12-08 18:13:41 +0000 net/krill: Update version 0.14.2=>0.14.3 Changelog: https://github.com/NLnetLabs/krill/releases/tag/v0.14.3 PR: 275633 Approved by: submitter is maintainer net/krill/Makefile | 4 +-- net/krill/Makefile.crates | 30 +++++++++++---------- net/krill/distinfo | 66 ++++++++++++++++++++++++++--------------------- 3 files changed, 56 insertions(+), 44 deletions(-)