Bug 275643 - lang/emilua: Update to 0.5.1
Summary: lang/emilua: Update to 0.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://docs.emilua.org/api/0.5/chang...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-12-08 23:57 UTC by Valter Nazianzeno
Modified: 2023-12-11 09:06 UTC (History)
2 users (show)

See Also:


Attachments
Diff for 0.5.1 (13.92 KB, patch)
2023-12-08 23:57 UTC, Valter Nazianzeno
manipuladordedados: maintainer-approval+
Details | Diff
[Fixed] Diff for 0.5.1 (13.94 KB, patch)
2023-12-09 21:58 UTC, Valter Nazianzeno
manipuladordedados: maintainer-approval+
Details | Diff
[Fixed] Diff for 0.5.1 (14.03 KB, patch)
2023-12-10 23:02 UTC, Valter Nazianzeno
manipuladordedados: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Valter Nazianzeno 2023-12-08 23:57:12 UTC
Created attachment 246917 [details]
Diff for 0.5.1

Some new features include:

* Enable IPC-based actors on all UNIX systems.

* spawn_vm() performs the same module path resolution from require() now. That means it’s possible to use root-imports from spawn_vm().

* spawn_vm() parameters refactored (API break).

* Add FreeBSD Capsicum support.

Etc.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-09 12:15:58 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-09 18:34:11 UTC
===>  Configuring for emilua-0.5.1
WARNING: Recommend using either -Dbuildtype or -Doptimization + -Ddebug. Using both is redundant since they override each other. See: https://mesonbuild.com/Builtin-options.html#build-type-options
The Meson build system
Version: 1.3.0
Source dir: /wrkdirs/usr/ports/lang/emilua/work/emilua-v0.5.1
Build dir: /wrkdirs/usr/ports/lang/emilua/work/emilua-v0.5.1/_build
Build type: native build
Project name: emilua
Project version: 0.5.1
C++ compiler for the host machine: g++12 (gcc 12.2.0 "g++12 (FreeBSD Ports Collection) 12.2.0")
C++ linker for the host machine: g++12 ld.bfd 2.40
Host machine cpu family: x86_64
Host machine cpu: x86_64
Configuring config.h using configuration
Run-time dependency threads found: YES
Found pkg-config: YES (/usr/local/bin/pkgconf) 2.0.3
Run-time dependency luajit found: YES 2.1.1694357807
Run-time dependency Boost (found: nowide) found: YES 1.83.0
Found CMake: /usr/local/bin/cmake (3.27.9)
Run-time dependency fmt found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency fmt

meson.build:32:6: ERROR: Automatic wrap-based subproject downloading is disabled

A full log can be found at /wrkdirs/usr/ports/lang/emilua/work/emilua-v0.5.1/_build/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
===>  Script "configure" failed unexpectedly.
Please report the problem to manipuladordedados@gmail.com [maintainer] and
attach the
"/wrkdirs/usr/ports/lang/emilua/work/emilua-v0.5.1/_build/meson-logs/meson-log.txt"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Are you sure removing the patch for meson is right?
Comment 3 Valter Nazianzeno 2023-12-09 21:58:39 UTC
Created attachment 246941 [details]
[Fixed] Diff for 0.5.1

Oh, I apologize, it was a last-minute mistake; I accidentally removed the libfmt. I have already updated the file.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-10 17:41:44 UTC
(In reply to Valter Nazianzeno from comment #3)
This does not build in anything < 14. Is this known?

In 12.4:

FAILED: libemilua.so.0.5.1.p/meson-generated_bc2_filesystem.cpp.o 
g++12 -Ilibemilua.so.0.5.1.p -Iinclude -I../include -I../subprojects/trial-protocol/include -I../subprojects/emilua-http/include -I/usr/local/include -I/usr/loc
al/include/luajit-2.1 -I/usr/local/include/serd-0 -I/usr/local/include/sord-0 -I/usr/local/include/zix-0 -fdiagnostics-color=never -D_FILE_OFFSET_BITS=64 -Wall 
-Winvalid-pch -std=c++20 -DBOOST_DLL_USE_STD_FS -DBOOST_ASIO_DISABLE_CO_AWAIT -DBOOST_ASIO_DISABLE_STD_COROUTINE -DBOOST_BEAST_USE_STD_STRING_VIEW -O2 -pipe -fs
tack-protector-strong -Wl,-rpath=/usr/local/lib/gcc12 -DFMT_HEADER_ONLY -Wl,-rpath=/usr/local/lib/gcc12 -fPIC -DBOOST_NOWIDE_DYN_LINK=1 -DBOOST_ALL_NO_LIB -pthr
ead -MD -MQ libemilua.so.0.5.1.p/meson-generated_bc2_filesystem.cpp.o -MF libemilua.so.0.5.1.p/meson-generated_bc2_filesystem.cpp.o.d -o libemilua.so.0.5.1.p/me
son-generated_bc2_filesystem.cpp.o -c libemilua.so.0.5.1.p/bc2_filesystem.cpp
libemilua.so.0.5.1.p/bc2_filesystem.cpp: In function 'int emilua::current_working_directory(lua_State*)':
libemilua.so.0.5.1.p/bc2_filesystem.cpp:4262:15: error: 'memfd_create' was not declared in this scope; did you mean 'timer_create'?
 4262 |         mfd = memfd_create("emilua/current_working_directory", /*flags=*/0);
      |               ^~~~~~~~~~~~
      |               timer_create

In 13.2:
FAILED: libemilua.so.0.5.1.p/meson-generated_bc2_ipc_actor.cpp.o 
g++12 -Ilibemilua.so.0.5.1.p -Iinclude -I../include -I../subprojects/trial-protocol/include -I../subprojects/emilua-http/include -I/usr/local/include -I/usr/loc
al/include/luajit-2.1 -I/usr/local/include/serd-0 -I/usr/local/include/sord-0 -I/usr/local/include/zix-0 -fdiagnostics-color=never -D_FILE_OFFSET_BITS=64 -Wall 
-Winvalid-pch -std=c++20 -DBOOST_DLL_USE_STD_FS -DBOOST_ASIO_DISABLE_CO_AWAIT -DBOOST_ASIO_DISABLE_STD_COROUTINE -DBOOST_BEAST_USE_STD_STRING_VIEW -O2 -pipe -fs
tack-protector-strong -Wl,-rpath=/usr/local/lib/gcc12 -DFMT_HEADER_ONLY -Wl,-rpath=/usr/local/lib/gcc12 -fPIC -DBOOST_NOWIDE_DYN_LINK=1 -DBOOST_ALL_NO_LIB -pthr
ead -MD -MQ libemilua.so.0.5.1.p/meson-generated_bc2_ipc_actor.cpp.o -MF libemilua.so.0.5.1.p/meson-generated_bc2_ipc_actor.cpp.o.d -o libemilua.so.0.5.1.p/meso
n-generated_bc2_ipc_actor.cpp.o -c libemilua.so.0.5.1.p/bc2_ipc_actor.cpp
libemilua.so.0.5.1.p/bc2_ipc_actor.cpp: In static member function 'static int emilua::app_context::ipc_actor_service_main(int)':
libemilua.so.0.5.1.p/bc2_ipc_actor.cpp:1205:5: error: 'clearenv' was not declared in this scope; did you mean 'clearerr'?
 1205 |     clearenv();
      |     ^~~~~~~~
Comment 5 Valter Nazianzeno 2023-12-10 23:02:08 UTC
Created attachment 246961 [details]
[Fixed] Diff for 0.5.1

Indeed, the new version only works on newer versions; I have modified the Makefile.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-12-11 09:06:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=00ddef6817476cac1e66fbfd56861d89d7240b5c

commit 00ddef6817476cac1e66fbfd56861d89d7240b5c
Author:     Valter Nazianzeno <manipuladordedados@gmail.com>
AuthorDate: 2023-12-10 16:48:52 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-12-11 09:06:32 +0000

    lang/emilua: Update to 0.5.1

    Does not build in FreeBSD releases < 14

    ChangeLog: https://docs.emilua.org/api/0.5/changelog.html#0-5

    PR:             275643
    Reported by:    manipuladordedados@gmail.com (maintainer)

 lang/emilua/Makefile                         |  28 +--
 lang/emilua/distinfo                         |   6 +-
 lang/emilua/files/patch-meson.build (gone)   |  19 --
 lang/emilua/files/patch-src_mutex.cpp (gone) |  10 --
 lang/emilua/pkg-plist                        | 252 ++++++++++++++-------------
 5 files changed, 149 insertions(+), 166 deletions(-)
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-11 09:06:55 UTC
Committed,

Thanks!