Bug 275658 - net/keycloak: User/group hardcoded to www/www
Summary: net/keycloak: User/group hardcoded to www/www
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 276859
  Show dependency treegraph
 
Reported: 2023-12-09 16:31 UTC by Tobias Bölz
Modified: 2024-02-20 17:39 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Bölz 2023-12-09 16:31:49 UTC
In the port's Makefile, user and group are hardcoded to www.

    USER=		www
    GROUP=		www

I would suggest, for the reason stated in the Porter's Handbook[^1], changing it to a dedicated `keycloak` user and group (or, if for some reason user and group should still default to www, at least using the `WWWOWN` and `WWWGRP` variables).

[^1]: See the Important box under https://docs.freebsd.org/en/books/porters-handbook/book/#web-apps.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-02-20 17:38:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=17afe60229c0d18c7f0d38fc7412d17abcffbc39

commit 17afe60229c0d18c7f0d38fc7412d17abcffbc39
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2024-02-20 17:33:39 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2024-02-20 17:36:48 +0000

    net/keycloak: update to 23.0.6

    - Update to 23.0.6
    - Add keycloak user and group
    - Add pkg-message
    - Add support for development(start-dev) and production (start) mode at rc script
    - Export JAVA_HOME from rc script
    - Add keycloak build function into rc script

    PR:             275658 276859
    Approved by:    maintainer timeout (2 weeks)

 GIDs                                    |  2 +-
 UIDs                                    |  2 +-
 net/keycloak/Makefile                   | 19 +++++++----
 net/keycloak/distinfo                   |  6 ++--
 net/keycloak/files/keycloak.in          | 15 +++++++--
 net/keycloak/files/pkg-message.in (new) | 58 +++++++++++++++++++++++++++++++++
 net/keycloak/pkg-plist                  |  6 ++--
 7 files changed, 93 insertions(+), 15 deletions(-)
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-02-20 17:39:40 UTC
Hello, latest version of net/keycloak includes keycloak user and group. Thanks for your PR