Created attachment 247091 [details] [PATCH 1/2] x11/xdialog: address warnings from portlint -A Since bsdconfig may be presumed as always available, and uses xdialog when invoked for use as a graphical interface (ie with -X), this package may just as well expose bsdconfig to the end user. This also installs a scaled-down copy of the FreeBSD logo from /boot/images for use as its icon (48 pixels tall and wide), where the trademark sign was removed since it is unrecognizable as this scale. Finally, this also documents the requirements in pkg-message. (Running as root or being a sudoer)
Created attachment 247092 [details] [PATCH 2/2] x11/xdialog: register bsdconfig as an application
Created attachment 247093 [details] Screenshot from the MATE desktop environment
Created attachment 247094 [details] Screenshot from the XFCE4 desktop environment
Since bsdconfig may be presumed as always available, and uses xdialog when invoked for use as a graphical interface (ie with -X), this package may just as well expose bsdconfig to the end user. This also installs a scaled-down copy of the FreeBSD logo from /boot/images for use as its icon (48 pixels tall and wide), where the trademark sign was removed since it is unrecognizable as this scale. Finally, this also documents the requirements in pkg-message. (Running as root or being a sudoer)
How did this get assigned to me? I don't know squat about xdialog. Re-assigning to ports@
Comment on attachment 247091 [details] [PATCH 1/2] x11/xdialog: address warnings from portlint -A ^Triage: convert this to text/plain and set the Patch flag so that the automation can see it.
@Pierre: I tried to apply this, and the png did NOT get created. Can you fix?
Created attachment 247888 [details] bsdconfig-48.png
(In reply to Larry Rosenman from comment #7) Hi Larry, I guess I simply forgot to add the PNG file to the patch before uploading it here. I have just added it to this bug report as an attachment.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a2e8585ffdf110d5fcc05fa54b7524380a7d9afe commit a2e8585ffdf110d5fcc05fa54b7524380a7d9afe Author: Larry Rosenman <ler@FreeBSD.org> AuthorDate: 2024-01-26 22:53:58 +0000 Commit: Larry Rosenman <ler@FreeBSD.org> CommitDate: 2024-01-26 22:56:22 +0000 x11/xdialog: Register bsdconfig as an application in x11/xdialog Since bsdconfig may be presumed as always available, and uses xdialog when invoked for use as a graphical interface (ie with -X), this package may just as well expose bsdconfig to the end user. This also installs a scaled-down copy of the FreeBSD logo from /boot/images for use as its icon (48 pixels tall and wide), where the trademark sign was removed since it is unrecognizable as this scale. Finally, this also documents the requirements in pkg-message. (Running as root or being a sudoer) PR: 275796 Reported by: khorben@defora.org x11/xdialog/Makefile | 13 +++++++++++-- x11/xdialog/files/bsdconfig-48.png (new) | Bin 0 -> 5209 bytes x11/xdialog/files/bsdconfig.desktop (new) | 12 ++++++++++++ x11/xdialog/pkg-message (new) | 5 +++++ x11/xdialog/pkg-plist | 3 +++ 5 files changed, 31 insertions(+), 2 deletions(-)
Committed, thanks!