Bug 276012 - lang/fpc: stage-qa fails, sample config files contain STAGEDIR
Summary: lang/fpc: stage-qa fails, sample config files contain STAGEDIR
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-30 02:58 UTC by John Hein
Modified: 2024-01-05 17:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
[patch] fix paths in .cfg files (1.41 KB, patch)
2024-01-03 06:51 UTC, John Hein
jcfyecrayz: maintainer-approval? (acm)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2023-12-30 02:58:07 UTC
'make -C lang/fpc stage stage-qa' results in:

====> Running Q/A tests (stage-qa)
Error: 'etc/fppkg.cfg.sample' is referring to /usr/ports/lang/fpc/work/stage
Error: 'etc/fppkg/default' is referring to /usr/ports/lang/fpc/work/stage
Error: 'lib/fpc/3.2.2/ide/text/fp.cfg' is referring to /usr/ports/lang/fpc/work/stage
*** Error code 1

Stop.
make: stopped in /usr/ports/lang/fpc
Comment 1 John Hein 2024-01-03 06:51:28 UTC
Created attachment 247429 [details]
[patch] fix paths in .cfg files

The attached patch fixes the pathnames written in sample config files so they do not contain the path to the 'work/stage' directory (as noticed by 'make stage-qa').  

QA testing:
  poudriere testport: ok
  portlint: no new warnings or errors
  portclippy: no new misordered lines
  portfmt: no new formatting improvement suggestions
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-01-03 21:59:40 UTC
Hello Jhon, I committed another fix for this qa issue. Sorry I put a wrong entry at PR: into commit message .Thanks for your PR

https://cgit.freebsd.org/ports/commit/?id=2f5457bf2c02580361ab6016b54a6a6e664401ef
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-01-05 08:35:58 UTC
FWIW, staging in strict plist-check mode still fails for me, could you take a look?

====================<phase 7: make package>====================
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/fpc/%%PORTVERSION%%/units/%%BUILDNAME%%/graph/sdlgraph.o
Error: Orphaned: lib/fpc/%%PORTVERSION%%/units/%%BUILDNAME%%/graph/sdlgraph.ppu
Error: Orphaned: lib/fpc/%%PORTVERSION%%/units/%%BUILDNAME%%/sdl/sdlutils.o
Error: Orphaned: lib/fpc/%%PORTVERSION%%/units/%%BUILDNAME%%/sdl/sdlutils.ppu
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
Comment 4 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-01-05 14:39:14 UTC
(In reply to Alexey Dokuchaev from comment #3)
Hello Alexey, are you testing on amd64 or i386?
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-01-05 15:51:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74dbced73dda83b3f93437d593605e18a3085380

commit 74dbced73dda83b3f93437d593605e18a3085380
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2024-01-05 15:45:56 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2024-01-05 15:50:01 +0000

    lang/fpc: Fix issues on stage-qa on i386

    - Add ptc unit
    - graph unit installs new unit files
    - Bump PORTREVISION

    PR:             276012
    Reported by:    danfe

 lang/fpc/Makefile                                  |  4 +-
 .../fpc/files/patch-packages-graph_fpmake.pp (new) | 53 ++++++++++++++++++++++
 lang/fpc/pkg-plist                                 | 17 +++++++
 3 files changed, 73 insertions(+), 1 deletion(-)
Comment 6 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-01-05 17:47:13 UTC
(In reply to Jose Alonso Cardenas Marquez from comment #4)
> Hello Alexey, are you testing on amd64 or i386?
Hey, guess what, you might be right: I've got this error on i386 (yeah, yeah, you don't need to tell me that I'm dumb and retarded, but this old Lenovo computer won't boot amd64 even though the CPU supports it).  Regardless, I've just git pulled and both i386/amd64 packages build fine for me now, thanks!