Bug 276096 - security/crowdsec-firewall-bouncer: update to 0.0.28-3
Summary: security/crowdsec-firewall-bouncer: update to 0.0.28-3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-03 12:26 UTC by marco
Modified: 2024-03-19 14:25 UTC (History)
1 user (show)

See Also:


Attachments
patch for crowdsec-firewall-bouncer 0.0.28.r3 (2.12 KB, patch)
2024-01-03 12:26 UTC, marco
marco: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description marco 2024-01-03 12:26:03 UTC
Created attachment 247430 [details]
patch for crowdsec-firewall-bouncer 0.0.28.r3

Fix an issue that may cause the application unable to authenticate when the provided or generated API key contains the '/' character, due to a yaml parsing quirk.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-03-14 14:18:33 UTC
Would you like this patch to be merged into the quarterly branch?
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-19 14:21:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7873631186c85b4d5bdcffa307f9dd49155c36c0

commit 7873631186c85b4d5bdcffa307f9dd49155c36c0
Author:     marco <marco@crowdsec.net>
AuthorDate: 2024-01-03 12:03:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-03-19 14:18:50 +0000

    security/crowdsec-firewall-bouncer: fix file quoting

    When the api key contains a '/' character, if the yaml field is
    not quoted it will include the comment as well. fix: quote the field and
    remove the comment with the bouncer name.

    PR:             276096
    MFH:            2024Q1

 security/crowdsec-firewall-bouncer/Makefile                   | 2 +-
 security/crowdsec-firewall-bouncer/files/crowdsec_firewall.in | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-19 14:24:46 UTC
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5ee0dd0975c31e9b0a705766c030d4741ca5c47c

commit 5ee0dd0975c31e9b0a705766c030d4741ca5c47c
Author:     marco <marco@crowdsec.net>
AuthorDate: 2024-01-03 12:03:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-03-19 14:23:29 +0000

    security/crowdsec-firewall-bouncer: fix file quoting

    When the api key contains a '/' character, if the yaml field is
    not quoted it will include the comment as well. fix: quote the field and
    remove the comment with the bouncer name.

    PR:             276096
    MFH:            2024Q1

    (cherry picked from commit 7873631186c85b4d5bdcffa307f9dd49155c36c0)

 security/crowdsec-firewall-bouncer/Makefile                   | 2 +-
 security/crowdsec-firewall-bouncer/files/crowdsec_firewall.in | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-03-19 14:25:11 UTC
Thank you for your contribution.