Bug 276117 - devel/gobject-introspection: make graphics/cairo dependency optional
Summary: devel/gobject-introspection: make graphics/cairo dependency optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-04 17:34 UTC by Siva Mahadevan
Modified: 2024-01-08 18:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (desktop)
me: maintainer-feedback? (desktop)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Siva Mahadevan 2024-01-04 17:34:29 UTC 
From upstream's gobject-introspection project, it's clear that cairo support is only required to enable some tests[0]. For people who just build this package as part of other pulled-in dependencies, or build minimal package repositories without graphics or X11 support, this unnecessary dependency on cairo brings in a ton of X11 dependencies as well.

Can we make graphics/cairo an optional dependency through an OPTIONS define? One that IMPLIES TESTS support as well? If help is needed on this, I can submit a patch.

[0] https://gitlab.gnome.org/GNOME/gobject-introspection/-/blob/main/meson.build?ref_type=heads#L201
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-01-08 18:26:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fc5be254502ef92e9f1acc28c7040f9c795e7b43

commit fc5be254502ef92e9f1acc28c7040f9c795e7b43
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2024-01-08 18:24:15 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-01-08 18:24:15 +0000

    devel/gobject-introspection: Move cairo dependency under TEST option.

    PR:             276117
    Reported by:    Siva Mahadevan <me@svmhdvn.name>

 devel/gobject-introspection/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2024-01-08 18:26:56 UTC 
Thank you for the suggestion!