Bug 276231 - devel/py-threadpoolctl: Mark broken on 13.2-RELEASE and earlier, add pytest
Summary: devel/py-threadpoolctl: Mark broken on 13.2-RELEASE and earlier, add pytest
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-10 02:05 UTC by Jason W. Bacon
Modified: 2024-03-09 14:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2024-01-10 02:05:46 UTC
py-threadpoolctl does not function properly on 13.2-RELEASE and earlier due to improper handling on dynamically loaded libc.  FreeBSD 13-STABLE and 14 are patched to handle the code correctly.

Suggest something like the following:

.include <bsd.port.options.mk>

.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1302509
BROKEN=         Does not run on FreeBSD 13.2 or earlier due to handling of dynamically loaded libc
.endif

Note: 1302509 is a later commit than the one with the fix, but it should be fine as nobody is likely depending on an earlier 13-STABLE.

Reference:

https://github.com/joblib/threadpoolctl/pull/148#discussion_r1446329259

Also, adding USE_PYTHON=pytest seems sufficient to enable "make test".
Comment 1 Jason W. Bacon freebsd_committer freebsd_triage 2024-01-10 14:10:16 UTC
IGNORE might be better than BROKEN, if this is not going to be patched.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-03-09 14:18:25 UTC
Since 13.3 is released, it is OK to commit this patch. Otherwise it would block some ports in a 13.2-RELEASE poudriere jail.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-09 14:19:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6fe6ac2e17648da3bc204470b67ea847cfe2cb43

commit 6fe6ac2e17648da3bc204470b67ea847cfe2cb43
Author:     Jason W. Bacon <jwb@freebsd.org>
AuthorDate: 2024-03-09 13:57:35 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-03-09 14:07:23 +0000

    devel/py-threadpoolctl: Mark IGNORE for FreeBSD 13.2-RELEASE

    PR:             276231

 devel/py-threadpoolctl/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-03-09 14:23:02 UTC
Committed. Thanks!