Bug 276260 - net/gmid: update to 2.0
Summary: net/gmid: update to 2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-11 16:41 UTC by Omar Polo
Modified: 2024-01-14 20:39 UTC (History)
1 user (show)

See Also:

Attachments
gmid-2.0.diff (1.67 KB, patch)
2024-01-11 16:41 UTC, Omar Polo 		no flags Details | Diff
Patch for gmid v2 (2.04 KB, patch)
2024-01-14 11:37 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Omar Polo 2024-01-11 16:41:31 UTC 
Created attachment 247598 [details]
gmid-2.0.diff

Hello,

please find attached a diff to update net/gmid to 2.0.
The full changelog is available here: <https://github.com/omar-polo/gmid/releases/tag/2.0>.


Cheers,

Omar Polo
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 09:16:19 UTC 
Any specific reason why Github is removed from MASTER_SITES?
Comment 2 Omar Polo 2024-01-14 10:27:53 UTC 
(In reply to Daniel Engberg from comment #1)

Not much.  github should still work as MASTER_SITE since I've uploaded the tarball there too (I'm both the maintainer and upstream for this port.)  However, I'd prefer to rely as less as possible on github and host the tarballs myself.

If you prefer to keep the MASTER_SITE on github however it's fine with me.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 10:29:53 UTC 
How about using GitHub is primary due to better connectivity and yours as fallback?
Comment 4 Omar Polo 2024-01-14 11:04:05 UTC 
Sure, fine with me.  If you can, feel free to go ahead with it, it'll take me a few hours to update the diff.

Thanks,
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 11:37:31 UTC 
Created attachment 247639 [details]
Patch for gmid v2

Add GitHub to MASTER_SITES
Slight adjustments to Makefile
Strip binaries
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 11:38:44 UTC 
Does this patch look ok to you?
Comment 7 Omar Polo 2024-01-14 11:42:20 UTC 
looks perfect to me, thank you!
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-01-14 20:37:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=734004ab94697ff6ac7df3679d5f7bcf4b7784b8

commit 734004ab94697ff6ac7df3679d5f7bcf4b7784b8
Author:     Omar Polo <freebsd@omarpolo.com>
AuthorDate: 2024-01-14 11:44:53 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-01-14 20:31:22 +0000

    net/gmid: Update to 2.0

    * Add https://ftp.omarpolo.com/ to MASTER_SITES
    * Minor adjustments to Makefile
    * Strip binaries

    Changelog: https://github.com/omar-polo/gmid/releases/tag/2.0

    PR:             276260

 net/gmid/Makefile  | 17 ++++++++++-------
 net/gmid/distinfo  |  6 +++---
 net/gmid/pkg-plist |  6 +++++-
 3 files changed, 18 insertions(+), 11 deletions(-)
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 20:39:36 UTC 
Committed, thanks for your contribution!