Bug 276340 - [NEW PORT] devel/rust-mode: A major-mode for editing Rust source code
Summary: [NEW PORT] devel/rust-mode: A major-mode for editing Rust source code
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks: 276338
  Show dependency tree / graph
 
Reported: 2024-01-14 23:52 UTC by Pat Maddox
Modified: 2024-01-24 01:58 UTC (History)
1 user (show)

See Also:

Attachments
new port (4.10 KB, patch)
2024-01-15 01:18 UTC, Pat Maddox 		pat: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pat Maddox 2024-01-14 23:52:25 UTC 

    


    


      



        
          Comment 1
        

        
          Pat Maddox

        

        
        

        
          2024-01-15 01:18:34 UTC
        

      






Created attachment 247666 [details]
new port

    


    


      



        
          Comment 2
        

        
          Yuri Victorovich

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-24 01:32:13 UTC
        

      






Hi Pat,

You set PORTVERSION incorrectly in your port submissions.
PORTVERSION=20230805.1558 is not what it should be.

This command:
$ git describe --tags
is what should be used.

I use this script:
> #!/bin/sh
> 
> REPO=$1
> REV=$2
> 
> DIR=$(echo $1 | sed -e 's|.*/|| ; s|\.git$||')
> 
> # For weird tags we can use the previous format:
> # ex: git describe --tags --match 6.8.1-release origin/master
> 
> (
>   git clone $REPO &&
>   (cd $DIR && git describe --tags $REV) &&
>   rm -rf $DIR
> )

    


    


      



        
          Comment 3
        

        
          Yuri Victorovich

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-24 01:37:39 UTC
        

      






Committed with minor alterations.

    


    


      



        
          Comment 4
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-24 01:38:10 UTC
        

      






A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8099c6d33d7690d53b135eedab5043fb9589a1ea

commit 8099c6d33d7690d53b135eedab5043fb9589a1ea
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2024-01-24 01:35:30 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-01-24 01:37:28 +0000

    devel/rust-mode: New port: Emacs major-mode for editing Rust source code

    PR:             276340
    Submitted by:   Pat Maddox <pat@patmaddox.com>

 devel/Makefile                  |  1 +
 devel/rust-mode/Makefile (new)  | 27 +++++++++++++++++++++++++++
 devel/rust-mode/distinfo (new)  |  3 +++
 devel/rust-mode/pkg-descr (new) | 17 +++++++++++++++++
 devel/rust-mode/pkg-plist (new) |  6 ++++++
 5 files changed, 54 insertions(+)

    


    


      



        
          Comment 5
        

        
          Pat Maddox

        

        
        

        
          2024-01-24 01:58:48 UTC
        

      






(In reply to Yuri Victorovich from comment #2)

I set the version based on Melpa package version: https://melpa.org/#/rust-mode