Bug 276396 - devel/py-pyinstaller: Update to 6.3.0
Summary: devel/py-pyinstaller: Update to 6.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-python (Nobody)
URL: https://github.com/pyinstaller/pyinst...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-17 04:53 UTC by Alastair Hogge
Modified: 2024-01-19 14:30 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (python)


Attachments
Update to 6.3.0 (9.71 KB, patch)
2024-01-17 04:53 UTC, Alastair Hogge
no flags Details | Diff
Update to 6.3.0 (9.87 KB, patch)
2024-01-17 14:14 UTC, Alastair Hogge
no flags Details | Diff
Update to 6.3.0 (9.85 KB, patch)
2024-01-18 12:47 UTC, Alastair Hogge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2024-01-17 04:53:51 UTC
Created attachment 247718 [details]
Update to 6.3.0

Update to 6.3.0:
- Update License block to reflect all licenses the project consumes
- Switch to PEP517 build
- Depend on Sphinx for building HTML, and the manual page documentation
- Add pytest to ${USES}, and populate ${TEST_DEPENDS}

https://github.com/pyinstaller/pyinstaller/compare/v3.5...v6.3.0
Comment 1 Alastair Hogge 2024-01-17 06:00:12 UTC
poudriere-testport (with Sneklang 3.11):
13_2-{amd64,i386}-release : OK
14_0-{amd64,i386}-release : OK
main-{amd64,i386}         : OK
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2024-01-17 06:35:06 UTC
According to https://reviews.freebsd.org/D39304#989004 this port also needs another one. Or does 6.3 version not require hooks anymore?
Comment 3 Alastair Hogge 2024-01-17 08:18:49 UTC
(In reply to Gleb Popov from comment #2)

No idea. Will make an attempt to understand and find out.
Comment 4 Alastair Hogge 2024-01-17 14:14:54 UTC
Created attachment 247727 [details]
Update to 6.3.0

* Update ${MAINTAINER}
* Add runtime dependency on devel/pyinstaller-hooks-contrib[1]

1: https://reviews.freebsd.org/D39305
Comment 5 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-01-18 09:59:21 UTC
Install via pip install producing those dependencies:

Successfully installed altgraph-0.17.4 packaging-23.2 pyinstaller-6.3.0 pyinstaller-hooks-contrib-2023.12

so, pyinstaller-hooks-contrib is indeed needed
Comment 6 Alastair Hogge 2024-01-18 11:01:39 UTC
(In reply to Ruslan Makhmatkhanov from comment #5)

Thank you for checking that.
Comment 7 Alastair Hogge 2024-01-18 12:47:11 UTC
Created attachment 247740 [details]
Update to 6.3.0

* move pytest to ${USE_PYTHON}
* sort ${COPYTREE_SHARE} exclusion arguments alphabetically
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-01-18 18:16:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=05b066f1d9e1ce81942c3ff11aa7898653b75a95

commit 05b066f1d9e1ce81942c3ff11aa7898653b75a95
Author:     Christopher Hall <hsw@bitmark.com>
AuthorDate: 2024-01-18 18:06:07 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-01-18 18:14:49 +0000

    devel/py-pyinstaller-hooks-contrib: The PyInstaller community hooks repository.

    This repository is a collection of hooks for many packages, and allows
    PyInstaller to work with these packages seamlessly.

    Differential Revision: https://reviews.freebsd.org/D43478

    Co-authored-by: Alastair Hogge <agh@riseup.net>

    PR:             276396

 devel/Makefile                                     |  1 +
 devel/py-pyinstaller-hooks-contrib/Makefile (new)  | 35 ++++++++++++++++++++++
 devel/py-pyinstaller-hooks-contrib/distinfo (new)  |  3 ++
 devel/py-pyinstaller-hooks-contrib/pkg-descr (new) |  8 +++++
 4 files changed, 47 insertions(+)
Comment 9 Gleb Popov freebsd_committer freebsd_triage 2024-01-18 18:47:04 UTC
Alastair, did you base your patch on https://reviews.freebsd.org/D39304 ?

In other words, should I add "Co-authored-by:" tag to the commit message to give a credit to Christopher?
Comment 10 Alastair Hogge 2024-01-18 22:48:20 UTC
(In reply to Gleb Popov from comment #9)

Only devel/py-pyinstaller-hooks-contrib was built on Christopher's labour, so yes please, a 1000 attributions directed at Christopher for that. This Port, this bug report, was developed in isolation, and ignorance of Christopher's work on devel/py-pyinstaller.

Summary:
devel/py-pyinstaller: without Christopher
devel/py-pyinstaller-hooks-contrib: with Christopher's work.
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-01-19 14:29:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2d5a85b7b9d2af3a34406ceb093ccf67373e4ee4

commit 2d5a85b7b9d2af3a34406ceb093ccf67373e4ee4
Author:     Alastair Hogge <agh@riseup.net>
AuthorDate: 2024-01-18 18:51:07 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-01-19 14:28:56 +0000

    devel/py-pyinstaller: Update to 6.3.0

    PR:             276396

 devel/py-pyinstaller/Makefile                      | 72 ++++++++++++----------
 devel/py-pyinstaller/distinfo                      |  6 +-
 .../files/patch-bootloader_src_main.c              | 48 ++++++---------
 .../files/patch-bootloader_wscript (gone)          | 20 ------
 .../files/patch-doc_help2rst.py (gone)             | 12 ----
 devel/py-pyinstaller/pkg-plist (gone)              |  2 -
 6 files changed, 61 insertions(+), 99 deletions(-)
Comment 12 Gleb Popov freebsd_committer freebsd_triage 2024-01-19 14:30:17 UTC
Pushed in, thanks!