Bug 276726 - net/widentd: updates, new MASTERSITE on VCS now encouraging public review
Summary: net/widentd: updates, new MASTERSITE on VCS now encouraging public review
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gleb Popov
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-01-30 00:13 UTC by Chris Hutchinson
Modified: 2024-03-02 11:47 UTC (History)
2 users (show)

See Also:
portmaster: maintainer-feedback+


Attachments
patch for net/widentd (2.32 KB, patch)
2024-01-30 00:13 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
updated patch for net/widentd (version 2) (2.31 KB, patch)
2024-02-02 04:27 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
patch against net/widentd (version 3) (1.82 KB, patch)
2024-03-01 23:13 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-01-30 00:13:17 UTC
Created attachment 248074 [details]
patch for net/widentd

The attached patch updates net/widentd. This program
worked without problems. But was DEPRECIATED for lack
of activity. As this program worked flawlessly. It seemed
prudent to move this to a public VCS to encourage public
review and promote improvements that otherwise may not
have occurred.

CHANGES
Makefile
distinfo
files/patch-widentd.c

That's it, thanks!

--Chris
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-02-02 02:27:48 UTC
Use https://codeberg.org/${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/

What's the reason to keep this in (already dropped all other distros)?
Comment 2 Chris Hutchinson 2024-02-02 03:10:47 UTC
(In reply to Daniel Engberg from comment #1)
Why use FreeBSD, when Linux is so much more popular?
I can't speak for other distros. Not sure it even applies.
But it works well and as intended. Now that it's on a public
VCS. Others can suggest/add improvements and/or features.
Besides, who doesn't like choices? :)

Thanks.

--Chris
Comment 3 Chris Hutchinson 2024-02-02 03:12:56 UTC
(In reply to Daniel Engberg from comment #1)
> https://codeberg.org/${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/

I'll check that out and update the patch.

Thanks, again.
Comment 4 Chris Hutchinson 2024-02-02 04:27:10 UTC
Created attachment 248128 [details]
updated patch for net/widentd (version 2)

Here's an update that's as close as I can get to your recommendation.
Your recommendation as it was failed as follows:

# make -DBATCH makesum
===>  License BSD3CLAUSE accepted by the user
===>  License BSD3CLAUSE accepted by the user
===>   widentd-1.05 depends on file: /usr/local/sbin/pkg - found
=> widentd-1.05.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://codeberg.org/BSDforge/widentd/archive/1.05.tar.gz?dummy=/widentd-1.05.tar.gz
fetch: https://codeberg.org/BSDforge/widentd/archive/1.05.tar.gz?dummy=/widentd-1.05.tar.gz: Not Found
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/widentd-1.05.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/widentd-1.05.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /usr/ports/distfiles/ and try again.
*** Error code 1

--Chris
Comment 5 Chris Hutchinson 2024-02-02 06:47:49 UTC
(In reply to Daniel Engberg from comment #1)
Just performed a count of installs for this port for
the month of January;

grep widentd-1.04.tar.xz /path/to/bsdwatch/access/log | grep libfetch |
grep -Eiv '(freebsd)' | awk '{print $1}' | uniq | wc -l
71

71. Not too bad for an old port? ;)

Just thought it worth mentioning. Probably even better in the future,
now that it's in a public VCS?
Comment 6 Gleb Popov freebsd_committer freebsd_triage 2024-03-01 18:40:38 UTC
The

${MV} ${WRKDIR}/widentd ${WRKDIR}/widentd-1.05

hack should be replaced with setting WRKSRC knob.
Comment 7 Chris Hutchinson 2024-03-01 23:13:09 UTC
Created attachment 248863 [details]
patch against net/widentd (version 3)

patch to (hopefully) address your comment about the WRKSRC hack.
I used:
${MV} ${WRKDIR}/${PORTNAME} ${WRKDIR}/${PORTNAME}-${DISTVERSION}
I required it only as USE_RC_SUBR gets confused over the WRK(DIR|SRC)
paradigm.

That's (hopefully) it. :)

Thanks for all your time and efforts here!

--Chris
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-03-02 11:47:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1704b36b05603fa914bdcf17fc967958e57ada76

commit 1704b36b05603fa914bdcf17fc967958e57ada76
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2024-03-02 11:45:12 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-03-02 11:45:12 +0000

    net/widentd: Update to 1.05

    PR:             276726

 net/widentd/Makefile | 26 +++++++++++++++++---------
 net/widentd/distinfo |  5 +++--
 2 files changed, 20 insertions(+), 11 deletions(-)