Created attachment 248277 [details] Patch to 4.2.2 Patch to 4.2.2 Upstream Changes: https://github.com/sabnzbd/sabnzbd/releases/tag/4.2.2 NOTE: Will require news/py-sabctools update to 8.1.0 which I will be submitting separately
news/py-sabctools diff and update request now at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276912
Created attachment 248279 [details] Maintainer Revised patch to 4.2.2 Thanks for submitting your patch, only a slight revision is needed - the version of sabctools the port depends on also needs to be bumped in the Makefile to match the update to 8.1.0 otherwise the port will fail when sabctools is committed. Thanks again, James
I changed the Makefile to "${PYTHON_PKGNAMEPREFIX}sabctools>0:news/py-sabctools@${PY_FLAVOR}" (which I grabbed from FreshPorts) so it automatically chooses the most recent version (if I understand it right, which I may not!) Thanks for the feedback, I'm hoping to do more in the ports tree if it turns out I'm not horrible at it :) Nick
Sorry, just re-read your message and I misunderstood the first time. I added a second bugfix to bump py-sabctools. I don't think you got auto-emailed on that one, but I did include the link in my last comment! 276912
Read it a third time and saw the difference in your diff file. It's pretty late here, lol. Thanks again!
(In reply to Nicholas Kirby from comment #4) Heya, I've seen the change to py-sabctools as well, thanks for that. Attachment 248277 [details] is missing your change to make the dependency version agnostic, but that's ok, I've fixed it by making it >=8.1, <8.2 We have been bitten previously letting the port depend on any version of sabctools (see bug 272071 for the most recent example). While sabnzbd is pretty flexible with the versions of a lot of its dependencies, it is understandably fussy about sabctools. It matters for the ports tree as the two ports have separate maintainers. Newer versions of the tools are often released before sabnzbd and are not always backwards-compatible with older versions. Being restrictive with the version offers a little bit of protection against incompatible versions being inadvertently committed to the tree and breaking sabnzbd before it's release catches up. Really appreciating you taking the time to update the port, other than that small fix your patch looks good to me.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cefc1d48dc34c3d454ae5ece864c4964b37e71f8 commit cefc1d48dc34c3d454ae5ece864c4964b37e71f8 Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> AuthorDate: 2024-03-09 17:11:03 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2024-03-09 17:13:13 +0000 news/sabnzbd: Update to 4.2.2 - While I'm here, use . instead of \* for COPYTREE_SHARE PR: 276911 Reported by: Nicholas Kirby <nick@kirby.cx> Approved by: James French <james@french.id.au> (maintainer) news/sabnzbd/Makefile | 8 ++++---- news/sabnzbd/distinfo | 6 +++--- news/sabnzbd/pkg-plist | 11 +++++++++-- 3 files changed, 16 insertions(+), 9 deletions(-)
Committed. Thanks!