Bug 277089 - sysutils/nut Fix build on arm by Fixing OPTIONS_DEFAULT
Summary: sysutils/nut Fix build on arm by Fixing OPTIONS_DEFAULT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-16 10:24 UTC by Olivier Cochard
Modified: 2024-03-23 04:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
fix build on arm (1.18 KB, patch)
2024-02-16 10:25 UTC, Olivier Cochard 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Cochard freebsd_committer freebsd_triage 2024-02-16 10:24:08 UTC 
Fix 2 problems with OPTIONS_DEFAULT:
1. The global OPTIONS_DEFAULT (without any _arch is overriding all others arch)
2. Need to use aarch64 in place of armv64

nut-devel need the same love.
With just an approval from the maintainer I will fix both.
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2024-02-16 10:25:01 UTC 
Created attachment 248504 [details]
fix build on arm
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-02-16 10:39:03 UTC 
IMHO, this is the correct way:
OPTIONS_DEFAULT= SERIAL USB SNMP NEON PDU MODBUS CGI BASH AVAHI DOCS MANPAGES OPENSSL
OPTIONS_DEFAULT_amd64= FREEIPMI
OPTIONS_DEFAULT_i386= FREEIPMI
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2024-02-16 13:31:09 UTC 
(In reply to Vladimir Druzenko from comment #2)

Agreed, this is the correct way.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-02-16 13:51:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=24114c15d5e7e3c9d1428460ca05a7067afa09d6

commit 24114c15d5e7e3c9d1428460ca05a7067afa09d6
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2024-02-16 13:43:46 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2024-02-16 13:50:03 +0000

    sysutils/nut*: Fix arm build

    Fix arm build by removing FREEIPMI from arm

    PR:             277089
    MFH:            2024Q1

 sysutils/nut-devel/Makefile | 12 ++++++++----
 sysutils/nut/Makefile       | 12 ++++++++----
 2 files changed, 16 insertions(+), 8 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-02-20 16:57:52 UTC 
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4ed86fa6c8af2ea3d5ea8cecd86a7a211c22ddb5

commit 4ed86fa6c8af2ea3d5ea8cecd86a7a211c22ddb5
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2024-02-16 13:43:46 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2024-02-20 16:57:04 +0000

    sysutils/nut*: Fix arm build

    Fix arm build by removing FREEIPMI from arm

    PR:             277089
    MFH:            2024Q1
    (cherry picked from commit 24114c15d5e7e3c9d1428460ca05a7067afa09d6)

 sysutils/nut-devel/Makefile | 12 ++++++++----
 sysutils/nut/Makefile       | 12 ++++++++----
 2 files changed, 16 insertions(+), 8 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-22 18:46:01 UTC 
You can use new option OPTIONS_DEFAULT_OTHER_ARCHS:
OPTIONS_DEFAULT_aarch64=
OPTIONS_DEFAULT_armv6=
OPTIONS_DEFAULT_armv7=
OPTIONS_DEFAULT_OTHER_ARCHS=   FREEIPMI

https://reviews.freebsd.org/D44228
https://cgit.freebsd.org/ports/commit/?id=cab93d2304d3214c4578ea5726dd519a3acd83d0
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2024-03-23 04:04:17 UTC 
(In reply to Vladimir Druzenko from comment #6)

That would certainly simplify it. I'll put this on my todo list. Thanks.