Bug 277091 - lang/go*: Introduce port Go 1.22
Summary: lang/go*: Introduce port Go 1.22
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-16 11:14 UTC by Ashish SHUKLA
Modified: 2024-03-06 22:22 UTC (History)
5 users (show)

See Also:


Attachments
Update diff (9.38 KB, patch)
2024-02-16 11:14 UTC, Ashish SHUKLA
no flags Details | Diff
diff for Mk/ (1.24 KB, patch)
2024-02-16 19:00 UTC, Ashish SHUKLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ashish SHUKLA freebsd_committer freebsd_triage 2024-02-16 11:14:13 UTC
Created attachment 248506 [details]
Update diff

Apparently, recent security/tailscale update requires Go 1.22


lang/go*: Update to Go 1.22 snapshot
    
    - Add overridable BUILD_DEPENDS on shells/bash, but only for Go 1.22+
    - Since lang/go121 also depends on it, allow SHEBANG_FILES to be
      overridden
    - Re-roll the patch
    - Update lang/go120 to co-exist with lang/go-devel update
    - Update lang/go121 to co-exist with lang/go-devel update

lang/go122: New Port
Comment 1 Konstantin Belousov freebsd_committer freebsd_triage 2024-02-16 15:04:54 UTC
I get the following from pkg version -vPL=
go122-1.22.0                       ?   orphaned: lang/go122
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2024-02-16 15:39:28 UTC
(In reply to Konstantin Belousov from comment #1)

AFAICT, it uses ports tree to deduce whether package needs upgrade, and lang/go122 is not in ports tree.
Comment 3 Konstantin Belousov freebsd_committer freebsd_triage 2024-02-16 16:23:01 UTC
(In reply to Ashish SHUKLA from comment #2)
Sure I have the patch applied on this machine.
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2024-02-16 18:52:43 UTC
(In reply to Konstantin Belousov from comment #3)

Aah, I see. In that case, you may need an entry in lang/Makefile to connect it to the build, only then it wouldn't be considered orphan as it seems, at least that's what caused it to be resolved for me.

HTH
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2024-02-16 19:00:29 UTC
Created attachment 248513 [details]
diff for Mk/
Comment 6 yzrh 2024-02-18 17:25:47 UTC
Go 1.22 also has support for openbsd ppc64 (powerpc64).
https://github.com/golang/go/issues/56001

Does it mean it will finally be possible to run go 
programmes on freebsd powerpc64 and powerpc64le?

Thanks
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-02-20 21:09:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=62772751bed611b591c4500dc41ec4a323203307

commit 62772751bed611b591c4500dc41ec4a323203307
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2024-02-11 10:42:41 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2024-02-20 21:08:00 +0000

    lang/go122: New port: Go release, version 1.22

    - Update Mk/* for Go 1.22

    PR:             277091

 Mk/Uses/go.mk                                         |  2 +-
 Mk/bsd.default-versions.mk                            |  2 +-
 lang/Makefile                                         |  1 +
 lang/go122/Makefile (new)                             | 19 +++++++++++++++++++
 lang/go122/distinfo (new)                             | 15 +++++++++++++++
 .../patch-src_cmd_go_internal_modload_vendor.go (new) | 11 +++++++++++
 6 files changed, 48 insertions(+), 2 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-02-20 21:09:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ccd8e6b89786dd2e9e30bfe65887811f9ecb69d6

commit ccd8e6b89786dd2e9e30bfe65887811f9ecb69d6
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2024-02-16 10:28:07 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2024-02-20 21:05:05 +0000

    lang/go*: Update to Go 1.22 snapshot

    - Add overridable BUILD_DEPENDS on shells/bash, but only for Go 1.22+
    - Since lang/go121 also depends on it, allow SHEBANG_FILES to be
      overridden
    - Re-roll the patch
    - Update lang/go120 to co-exist with lang/go-devel update
    - Update lang/go121 to co-exist with lang/go-devel update

    PR:             277091

 lang/go-devel/Makefile                               | 13 +++++++------
 lang/go-devel/distinfo                               |  6 +++---
 .../patch-src_cmd_go_internal_modload_vendor.go      | 20 ++++++++++----------
 lang/go120/Makefile                                  |  5 +++++
 lang/go121/Makefile                                  |  5 +++++
 5 files changed, 30 insertions(+), 19 deletions(-)
Comment 9 Ashish SHUKLA freebsd_committer freebsd_triage 2024-02-20 21:17:03 UTC
Committed.

(In reply to yzrh from comment #6)

I'm not sure, lack of access to powerpc64 host. Although, if you could verify this, and provide a diff, we can apply it.

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-03-06 22:22:06 UTC
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dac17f4e52e6f0e0bde3a9787b4fa22c3a8957f7

commit dac17f4e52e6f0e0bde3a9787b4fa22c3a8957f7
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2024-02-16 10:28:07 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2024-03-06 22:05:14 +0000

    lang/go*: Update to Go 1.22 snapshot

    - Add overridable BUILD_DEPENDS on shells/bash, but only for Go 1.22+
    - Since lang/go121 also depends on it, allow SHEBANG_FILES to be
      overridden
    - Re-roll the patch
    - Update lang/go120 to co-exist with lang/go-devel update
    - Update lang/go121 to co-exist with lang/go-devel update

    PR:             277091
    (cherry picked from commit ccd8e6b89786dd2e9e30bfe65887811f9ecb69d6)

 lang/go-devel/Makefile                               | 13 +++++++------
 lang/go-devel/distinfo                               |  6 +++---
 .../patch-src_cmd_go_internal_modload_vendor.go      | 20 ++++++++++----------
 lang/go120/Makefile                                  |  5 +++++
 lang/go121/Makefile                                  |  5 +++++
 5 files changed, 30 insertions(+), 19 deletions(-)