Bug 277216 - math/vtk9: fix build with OSMESA and JAVA option
Summary: math/vtk9: fix build with OSMESA and JAVA option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-22 01:40 UTC by Hiroo Ono
Modified: 2024-02-22 09:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Patch to fix build with OSMESA and JAVA option. (2.18 KB, patch)
2024-02-22 01:40 UTC, Hiroo Ono
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2024-02-22 01:40:22 UTC
Created attachment 248675 [details]
Patch to fix build with OSMESA and JAVA option.

The build of vtk9 fails if I choose JAVA or OSMESA option.
1) In the Makefile, a typo exists which make the build fail with JAVA option.
  The patch fixes it.
2) With OSMESA option,
 2-1) USE= gl should only be included with OSMESA option, but currently there is "gl" entry in the global USES line. there is also USES+=gl line with OSMESA option. It makes gl doubled (USES= gl gl) and seems to trigger a strange behavior that lead to build failure.
 2-2) need a little patch to the source to build with OSMESA option.

Tested with poudriere testport on 14-STABLE.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2024-02-22 09:38:21 UTC
Committed.

Thanks for the patch!
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-02-22 09:39:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=35b87f5972e2a55f4dd6704665eca9de71011ef3

commit 35b87f5972e2a55f4dd6704665eca9de71011ef3
Author:     Hiroo Ono <hiroo.ono+freebsd@gmail.com>
AuthorDate: 2024-02-22 09:24:21 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-02-22 09:38:42 +0000

    math/vtk9: Fix build with OSMESA and JAVA option

    PR:             277216

 math/vtk9/Makefile                                             |  6 +++---
 math/vtk9/files/patch-ThirdParty_glew_vtkglew_src_glew.c (new) | 10 ++++++++++
 .../files/patch-ThirdParty_glew_vtkglew_src_glewinfo.c (new)   | 10 ++++++++++
 3 files changed, 23 insertions(+), 3 deletions(-)