Bug 277282 - devel/raylib: update to 5.0
Summary: devel/raylib: update to 5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/raysan5/raylib/blo...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-24 16:35 UTC by Martin Filla
Modified: 2024-02-25 14:05 UTC (History)
1 user (show)

See Also:


Attachments
raylib.diff (2.87 KB, patch)
2024-02-24 16:35 UTC, Martin Filla
no flags Details | Diff
raylib.diff (3.52 KB, patch)
2024-02-25 13:17 UTC, Martin Filla
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2024-02-24 16:35:51 UTC
Created attachment 248718 [details]
raylib.diff

Hello, 
this is update to 5.0 version raylib
===========================================================================
=>> Checking shared library dependencies
 0x0000000000000001 NEEDED               Shared library: [libGLU.so.1]
 0x0000000000000001 NEEDED               Shared library: [libGLX.so.0]
 0x0000000000000001 NEEDED               Shared library: [libOpenGL.so.0]
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]
 0x0000000000000001 NEEDED               Shared library: [libglfw.so.3]
 0x0000000000000001 NEEDED               Shared library: [libm.so.5]
 0x0000000000000001 NEEDED               Shared library: [libthr.so.3]
=======================<phase: deinstall      >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes USER=root UID=0 GID=0
===>  Deinstalling for raylib
===>   Deinstalling raylib-5.0
Updating database digests format: .......... done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	raylib: 5.0

Number of packages to be removed: 1

The operation will free 2 MiB.
[freebsd132x64-default] [1/1] Deinstalling raylib-5.0...
[freebsd132x64-default] [1/1] Deleting files for raylib-5.0: .......... done
===========================================================================
=>> Checking for extra files and directories
[00:00:46] Installing from package
[freebsd132x64-default] Installing raylib-5.0...
[freebsd132x64-default] Extracting raylib-5.0: .......... done
[00:00:46] Cleaning up
===>  Cleaning for raylib-5.0
[00:00:46] Deinstalling package
Updating database digests format: . done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	raylib: 5.0

Number of packages to be removed: 1

The operation will free 2 MiB.
[freebsd132x64-default] [1/1] Deinstalling raylib-5.0...
[freebsd132x64-default] [1/1] Deleting files for raylib-5.0: .......... done
build of devel/raylib | raylib-5.0 ended at Sat Feb 24 17:30:17 CET 2024
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-02-24 20:15:59 UTC
Hello,

[When possible send a git patch]

Just a couple of doubts:

1. Why is defined both build and lib depends:

BUILD_DEPENDS=  glfw>=3.3:graphics/glfw
LIB_DEPENDS=    libglfw.so:graphics/glfw

when LIB_DEPENDS will be enough for linked libglfw.so.3?

2. As USE_EXTERNAL_GLFW is on, is it really needed to RM bundled glfw from source?

USE_EXTERNAL_GLFW "OFF;IF_POSSIBLE;ON" "Link raylib against system GLFW instead of embedded one"

Thanks
Comment 2 Martin Filla 2024-02-25 13:17:20 UTC
Created attachment 248729 [details]
raylib.diff

Hi,
thank you for your comment.
I changed Makefile.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2024-02-25 13:26:35 UTC
(In reply to Martin Filla from comment #2)

For my understanding, USE_EXTERNAL_GLFW "ON" will "Link raylib against system GLFW instead of embedded one"

No need to upload a new diff, as I need to do more testing.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-02-25 14:04:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=97dc4fa17b1ce14a2490f0761e49ca83b1f630c5

commit 97dc4fa17b1ce14a2490f0761e49ca83b1f630c5
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2024-02-25 13:56:50 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-02-25 14:04:04 +0000

    devel/raylib: Update to 5.0

    While here,

    - pet Q/A check by using opengl instead of gl in USE_GL
    - avoid unnecessary removal of bundled glfw as USE_EXTERNAL_GLFW is ON

    ChangeLog:      https://github.com/raysan5/raylib/blob/master/CHANGELOG
    PR:             277282

 devel/raylib/Makefile                                     |  9 ++-------
 devel/raylib/distinfo                                     |  6 +++---
 .../files/patch-cmake_LibraryConfigurations.cmake (gone)  | 11 -----------
 devel/raylib/files/patch-src_rcore.c (gone)               | 15 ---------------
 devel/raylib/pkg-plist                                    |  4 ++--
 5 files changed, 7 insertions(+), 38 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2024-02-25 14:05:53 UTC
Committed with small adjustments.
Thanks!