Created attachment 248733 [details] Patch for audio/logitechmediaserver Update Logitech Media Server to 8.4.0 https://github.com/Logitech/slimserver/blob/8.4.0/Changelog8.html Additional plugins, views, and the ability to import playlists from other services. Also, since mysqueezebox.com is going to close down imminently, add the --nomysqueezebox to the server invocation to make life easier.
This came from Logitech: After a more than ten year journey, as of February 2024, we will discontinue our UESmartRadio.com and MySqueezebox.com servers. We would like to thank you for your loyalty and support throughout this time. MySqueezebox.com is part of any existing logitechmediaserver, so they will all have negative behavior, as the server will not be available anymore soon! mherger has been working on resolving the upcoming issues and has released a stable 8-4-1 and work has begun on 8.5 https://lms-community.github.io/getting-started/changelog-lms8/#version-850 The LMS Community is very active and since Logitech is happy with this, the project is looking at a bright future, I'd say. LMS is also popular on TrueNAS Core and getting regular updated packages would be great! So on my behalf and many others, please commit soon. And if possible, keep an eye on the project, there will are more changes to come. Thanky very much.
testbuilds are fine, except 15-i386, with a plist error: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%SLIMDIR%%/Slim/Utils/OS/Win64.pm Error: Orphaned: %%SLIMDIR%%/lib/CGI/Util.pm ===> Checking for items in pkg-plist which are not in STAGEDIR
Hi Trenton, Thanks for your submission, aside from Kurt remarks who require to be fixed before commit, there is also other warnings reported by our linters[1]: portlint, portclippy and portfmt. If you are stuck searching a way to fix the issues, don't hesitate to ask or submit ideas. [1] https://docs.freebsd.org/en/books/porters-handbook/book/#testing-portclippy
Created attachment 249112 [details] Updated patch to fix i386 pkg-plist issue My apologies. I thought I had tested on i386 poudriere, but obviously didn't. Thanks for the catch! Here is the updated patch, which should build cleanly on i386. I don't have current available at the moment, so I hope it works in 15 as well. I see that upstream now supports arm64 on Linux, so I'll have to explore making that work as well at some future update.
(In reply to Rodrigo Osorio from comment #3) I'll see if I can fix the linting issues. I seem to recall I looked at them before, but I've inherited the port and it does some "interesting" things with the port targets.
Created attachment 249116 [details] Updated patch to LMS 8.4.0 plus remove linting warnings OK. This patch should remove the most of the LINTING warnings. I'm not sure how to remove the "possible use of absolute pathname" as the variable points to /var/db/logitechmediaserver, and I'm not sure if there is a better way to handle it. I'm happy to hear ways to remove this warning. For the "considering adding NLS support"-warning, yes, that would be nice. I will consider it, but I'm not sure where to start with this, and I think that would be better to fix in a port revision, not in an update to a port. Less moving parts. Regardless, it seems to work well for amd64 and i386. Is this sufficient for this update?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fa8a46b47d4ee72181a46034aea2b39c230c8e5c commit fa8a46b47d4ee72181a46034aea2b39c230c8e5c Author: Rodrigo Osorio <rodrigo@FreeBSD.org> AuthorDate: 2024-03-13 15:26:53 +0000 Commit: Rodrigo Osorio <rodrigo@FreeBSD.org> CommitDate: 2024-03-13 17:16:59 +0000 audio/logitechmediaserver: update to 8.4.0 Changelog: https://github.com/Logitech/slimserver/blob/8.4.0/Changelog8.html Major changes: * Additional plugins, views * The ability to import playlists from other services Port changes: since mysqueezebox.com is going to close down imminently, add the --nomysqueezebox to the server invocation to make life easier https://lms-community.github.io/getting-started/changelog-lms8/#version-850 PR: 277299 Reported by: Trenton Schulz <trueos@norwegianrockcat.com> (maintainer) audio/logitechmediaserver/Makefile | 31 +- audio/logitechmediaserver/distinfo | 10 +- .../files/logitechmediaserver.in | 2 +- .../files/vendorpatch-CPAN_buildme.sh (gone) | 11 - audio/logitechmediaserver/pkg-plist | 59 +++- audio/logitechmediaserver/pkg-plist.i386 | 387 ++++++++++++--------- 6 files changed, 287 insertions(+), 213 deletions(-)
Committed with minor changes in message log, thanks