Created attachment 249459 [details] upgrade patch net/py-ripe.atlas.tools: Update to 3.1.0 - Update port to the most recent version - Fix missing runtime dependency - Change from PyPI to GitHub
Maintainer informed via mail
I installed it today but found it useless. Perhaps only the runtime dependency devel/py-typing-extensions package was missing, but I had some time to work on these RIPE Atlas tools and upgraded them to recent verions. Unfortunately, I wasn't able to find the required source tarballs on PyPI, so I switched to GitHub sources. Please either update the port or mark it broken. Cheers Marek
Looks good!
Why changing from pypi to github?
(In reply to Marek Zarychta from comment #2) https://pypi.org/project/ripe.atlas.tools/
(In reply to Max Stucchi from comment #3) Is net/py-ripe.atlas.* pep517 buildable?
(In reply to Marek Zarychta from comment #2) upstream didn't upload tarballs to PyPI, let's wait them to fixed it. https://github.com/RIPE-NCC/ripe-atlas-sagan/issues/95
Waiting on 3.1.1 changelog
Reopening, PR is open and waiting on upstream to proceed.
Comment on attachment 249459 [details] upgrade patch Undesired, spurious change from PyPi to GitHub
(In reply to Marek Zarychta from comment #10) Please don't close PRs. Thanks
(In reply to Nuno Teixeira from comment #11) What about closing them all and creating new ones with new update patches? AFAIK reporter/submitter is permitted to close PR at any time.
(In reply to Marek Zarychta from comment #12) Whats the sense of that? Close and create a new PR with new patches, while we could use same PR with progress history? Sure that reporter could close PRs, but that way is wrong.
(In reply to Nuno Teixeira from comment #13) (...) Also, a new patch could be uploaded and old patch obsoleted if necessary.
(In reply to Nuno Teixeira from comment #14) >Also, a new patch could be uploaded and old patch obsoleted if necessary. OK, let's wait for the patches then.
Created attachment 249897 [details] v0: pep517, pytest - Switch to DISTVERSION - Use pep517 build - Add pytest tests
Any progress on this update so we can proceed?
If what you're waiting for is maintainer approval again, approval.
(In reply to Max Stucchi from comment #18) Your answer is from e-mail max@stucchi.ch while maintainer's is mstucchi@ripe.net. Is maintainer e-mail outdated?
(In reply to Nuno Teixeira from comment #19) > Your answer is from e-mail max@stucchi.ch while maintainer's is mstucchi@ripe.net. > Is maintainer e-mail outdated? Please remember that the second email is not registered with Bugzilla, but the person does exist[1] and is an active contributor. 1. https://twitter.com/asiabsdcon/status/1772456148429316445
I have left RIPE NCC at the end of June 2019, so that e-mail address hasn't existed for about 5 years.
(In reply to Max Stucchi from comment #21) Updating your maintainer email is needed for your ports: net/py-ripe.atlas.cousteau net/py-ripe.atlas.sagan net/py-ripe.atlas.tools net/py-socketio-client Could you please open a PR with subject: --- net/py-{ripe.atlas.*,socketio-client}: Update maintainer e-mail address --- Thanks
(In reply to Nuno Teixeira from comment #22) (...) And upload a patch with updated e-mail for the four ports listed above.
(In reply to Max Stucchi from comment #21) I've created PR 278522 for email update. Could you check if change is correct? If evrything fine, check with '+' on maintainer-feedback=? Cheers
Ports committer Nuno Teixeira stepped in rejecting the original patch and demanding from the upstream to send sources to PyPi. After the upstream fulfilled request, the committer created new patch rebased on PyPi sources, but did not commit it, instead escalated requesting the change of maintainer's email address. As a reporter I am closing the PR since original patch was rejected. The port in current state is not functional and should be marked as BROKEN. Please submit new PR if you want to update the port.
(In reply to Marek Zarychta from comment #25) This week I will close 278522 and put maintainership on ports@. Are you ok if I reopen PRs when it's ready? Thanks
Reopening, reset maintainer completed.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=008ca2f8305d87b317418b473acec1be9b91022e commit 008ca2f8305d87b317418b473acec1be9b91022e Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2024-05-07 11:25:13 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-05-07 11:25:13 +0000 net/py-ripe.atlas.tools: Update to 3.1.1 - Switch to DISTVERSION - Use pep517 build - Add pytest tests - Take maintainership for the time being ChangeLog: https://pypi.org/project/ripe.atlas.tools/3.1.1/#history PR: 277936 Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> net/py-ripe.atlas.tools/Makefile | 27 +++++++++++++++++---------- net/py-ripe.atlas.tools/distinfo | 6 +++--- 2 files changed, 20 insertions(+), 13 deletions(-)
Committed, thanks!